Skip to content
Snippets Groups Projects

AARC IDP HINT implemented

Closed AARC IDP HINT implemented
github/fork/dBucik/aarc_idp_hinting into simplesamlphp-1.19.1
Closed Ghost User requested to merge github/fork/dBucik/aarc_idp_hinting into simplesamlphp-1.19.1

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pavel Břoušek
    Pavel Břoušek @433364

    Created by: BaranekD

    Review: Approved

  • Pavel Břoušek
    Pavel Břoušek @433364

    Created by: melanger

    Review: Commented

    It seems to me like a lot of changes for a quite simple feature.

    I suggest using parent:: instead of copy-pasting of method bodies and especially the Hook interface of SSP to avoid overriding a set of nested classes.

    But if it works, it is probably OK for the proxy :)

Please register or sign in to reply