From 36c849a7faa90c4f8fa77cff71ecabbc774edcd9 Mon Sep 17 00:00:00 2001 From: Dominik Frantisek Bucik <bucik@ics.muni.cz> Date: Tue, 28 Nov 2023 07:37:00 +0100 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=90=9B=20Potential=20Undefined=20a?= =?UTF-8?q?rray=20key=20in=20IsEinfrAssured?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix the `process` method of `IsEinfrAssured` authproc filter to not spam logs with undefined key if the attribute is not present in user attributes. --- lib/Auth/Process/IsEinfraAssured.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Auth/Process/IsEinfraAssured.php b/lib/Auth/Process/IsEinfraAssured.php index c340300..b153f9f 100644 --- a/lib/Auth/Process/IsEinfraAssured.php +++ b/lib/Auth/Process/IsEinfraAssured.php @@ -74,9 +74,9 @@ class IsEinfraAssured extends ProcessingFilter public function process(&$request) { $timestamp = 0; - if (isset($request['Attributes'][$this->sessionEligibilitiesAttr][$this->eligibilityKey])) { + if (!empty($request['Attributes'][$this->sessionEligibilitiesAttr][$this->eligibilityKey])) { $timestamp = $request['Attributes'][$this->sessionEligibilitiesAttr][$this->eligibilityKey]; - } elseif (isset($request['Attributes'][$this->userEligibilitiesAttr][$this->eligibilityKey])) { + } elseif (!empty($request['Attributes'][$this->userEligibilitiesAttr][$this->eligibilityKey])) { $timestamp = $request['Attributes'][$this->userEligibilitiesAttr][$this->eligibilityKey]; } -- GitLab