Skip to content
Snippets Groups Projects
  • Jaime Pérez Crespo's avatar
    abcfd1af
    Make sure the operation to generate a time-limited token is atomic. · abcfd1af
    Jaime Pérez Crespo authored
    With the previous implementation, several methods invoked time() themselves. Under certain conditions (basically, when the clock proceeds to the next second between computing the offset and calculating the token value), this could cause a mismatch that could make tokens expire before they are supposed to. Shouldn't be a big issue unless the system is really, really slow, but better safe than sorry.
    abcfd1af
    History
    Make sure the operation to generate a time-limited token is atomic.
    Jaime Pérez Crespo authored
    With the previous implementation, several methods invoked time() themselves. Under certain conditions (basically, when the clock proceeds to the next second between computing the offset and calculating the token value), this could cause a mismatch that could make tokens expire before they are supposed to. Shouldn't be a big issue unless the system is really, really slow, but better safe than sorry.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.