From 063ec03dd8743d9c7bcdcad71cc7c3c374864a70 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Tue, 25 Aug 2020 22:22:41 +0200
Subject: [PATCH] Remove or suppress unused param
---
lib/SimpleSAML/Auth/ProcessingFilter.php | 2 +-
lib/SimpleSAML/Metadata/MetaDataStorageHandlerPdo.php | 2 +-
lib/SimpleSAML/Stats/Output.php | 2 +-
modules/saml/lib/SP/LogoutStore.php | 4 +---
4 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/lib/SimpleSAML/Auth/ProcessingFilter.php b/lib/SimpleSAML/Auth/ProcessingFilter.php
index be5c2fc5c..038900e5e 100644
--- a/lib/SimpleSAML/Auth/ProcessingFilter.php
+++ b/lib/SimpleSAML/Auth/ProcessingFilter.php
@@ -47,7 +47,7 @@ abstract class ProcessingFilter
* @param array &$config Configuration for this filter.
* @param mixed $reserved For future use.
*/
- public function __construct(array &$config, $reserved)
+ public function __construct(array &$config, /** @scrutinizer ignore-unused */ $reserved)
{
if (array_key_exists('%priority', $config)) {
$this->priority = $config['%priority'];
diff --git a/lib/SimpleSAML/Metadata/MetaDataStorageHandlerPdo.php b/lib/SimpleSAML/Metadata/MetaDataStorageHandlerPdo.php
index 7d88000e1..8136c7aea 100644
--- a/lib/SimpleSAML/Metadata/MetaDataStorageHandlerPdo.php
+++ b/lib/SimpleSAML/Metadata/MetaDataStorageHandlerPdo.php
@@ -58,7 +58,7 @@ class MetaDataStorageHandlerPdo extends MetaDataStorageSource
*
* @param array $config An associative array with the configuration for this handler.
*/
- public function __construct(array $config)
+ public function __construct(/** @scrutinizer ignore-unused */ array $config)
{
$this->db = Database::getInstance();
}
diff --git a/lib/SimpleSAML/Stats/Output.php b/lib/SimpleSAML/Stats/Output.php
index 251bc63b0..89be3c8ef 100644
--- a/lib/SimpleSAML/Stats/Output.php
+++ b/lib/SimpleSAML/Stats/Output.php
@@ -19,7 +19,7 @@ abstract class Output
*
* @param \SimpleSAML\Configuration $config The configuration for this output.
*/
- public function __construct(Configuration $config)
+ public function __construct(/** @scrutinizer ignore-unused */ Configuration $config)
{
// do nothing by default
}
diff --git a/modules/saml/lib/SP/LogoutStore.php b/modules/saml/lib/SP/LogoutStore.php
index 47af236b7..9b8f423d2 100644
--- a/modules/saml/lib/SP/LogoutStore.php
+++ b/modules/saml/lib/SP/LogoutStore.php
@@ -291,14 +291,12 @@ class LogoutStore
* Retrieve all session IDs from a key-value store.
*
* @param \SimpleSAML\Store $store The datastore.
- * @param string $authId The authsource ID.
* @param string $nameId The hash of the users NameID.
* @param array $sessionIndexes The session indexes.
* @return array Associative array of SessionIndex => SessionId.
*/
private static function getSessionsStore(
Store $store,
- string $authId,
string $nameId,
array $sessionIndexes
): array {
@@ -412,7 +410,7 @@ class LogoutStore
// We cannot fetch all sessions without a SQL store
return false;
}
- $sessions = self::getSessionsStore($store, $authId, $strNameId, $sessionIndexes);
+ $sessions = self::getSessionsStore($store, $strNameId, $sessionIndexes);
}
if (empty($sessionIndexes)) {
--
GitLab