From 0b1501e8b67fcbf09c39339466b9be4b8bfa77f3 Mon Sep 17 00:00:00 2001
From: Jaime Perez Crespo <jaime.perez@uninett.no>
Date: Tue, 9 Feb 2016 11:13:55 +0100
Subject: [PATCH] Tests for SimpleSAML\Locale\Language::isLanguageRTL() + Typo.
---
lib/SimpleSAML/Locale/Language.php | 2 +-
tests/lib/SimpleSAML/Locale/LanguageTest.php | 30 ++++++++++++++++++++
2 files changed, 31 insertions(+), 1 deletion(-)
diff --git a/lib/SimpleSAML/Locale/Language.php b/lib/SimpleSAML/Locale/Language.php
index f163c5230..2bdcb6855 100644
--- a/lib/SimpleSAML/Locale/Language.php
+++ b/lib/SimpleSAML/Locale/Language.php
@@ -153,7 +153,7 @@ class Language
continue;
}
- /* Some user agents use very limited precicion of the quality value, but order the elements in descending
+ /* Some user agents use very limited precision of the quality value, but order the elements in descending
* order. Therefore we rely on the order of the output from getAcceptLanguage() matching the order of the
* languages in the header when two languages have the same quality.
*/
diff --git a/tests/lib/SimpleSAML/Locale/LanguageTest.php b/tests/lib/SimpleSAML/Locale/LanguageTest.php
index 2a9bf63b1..68aee869a 100644
--- a/tests/lib/SimpleSAML/Locale/LanguageTest.php
+++ b/tests/lib/SimpleSAML/Locale/LanguageTest.php
@@ -71,6 +71,36 @@ class LanguageTest extends \PHPUnit_Framework_TestCase
}
+ /**
+ * Test SimpleSAML\Locale\Language::isLanguageRTL().
+ */
+ public function testIsLanguageRTL()
+ {
+ // test defaults
+ $c = \SimpleSAML_Configuration::loadFromArray(array(), '', 'simplesaml');
+ $l = new Language($c);
+ $l->setLanguage('en');
+ $this->assertFalse($l->isLanguageRTL());
+
+ // test non-defaults, non-RTL
+ $c = \SimpleSAML_Configuration::loadFromArray(array(
+ 'language.rtl' => array('xx', 'yy', 'zz'),
+ ), '', 'simplesaml');
+ $l = new Language($c);
+ $l->setLanguage('en');
+ $this->assertFalse($l->isLanguageRTL());
+
+ // test non-defaults, RTL
+ $c = \SimpleSAML_Configuration::loadFromArray(array(
+ 'language.available' => array('xx', 'yy', 'zz', 'en'),
+ 'language.rtl' => array('xx', 'yy'),
+ ), '', 'simplesaml');
+ $l = new Language($c);
+ $l->setLanguage('yy');
+ $this->assertTrue($l->isLanguageRTL());
+ }
+
+
/**
* Test SimpleSAML\Locale\Language::setLanguage().
*/
--
GitLab