diff --git a/tests/lib/SimpleSAML/DatabaseTest.php b/tests/lib/SimpleSAML/DatabaseTest.php index b99575b66c556c191c0e198e5d05831adf91c36f..d15498221387d8a62c3f0adef9998dda8989ab10 100644 --- a/tests/lib/SimpleSAML/DatabaseTest.php +++ b/tests/lib/SimpleSAML/DatabaseTest.php @@ -92,7 +92,7 @@ class DatabaseTest extends TestCase ); $this->config = new \SimpleSAML\Configuration($config, "test/SimpleSAML/DatabaseTest.php"); - $db = SimpleSAML\Database::getInstance($this->config); + SimpleSAML\Database::getInstance($this->config); } diff --git a/tests/lib/SimpleSAML/Utils/CryptoTest.php b/tests/lib/SimpleSAML/Utils/CryptoTest.php index b5a0b500a966350542632a5b9f18035f623eaee1..0ef6513e3cb71ed6686b361047259d0b7e21d1a8 100644 --- a/tests/lib/SimpleSAML/Utils/CryptoTest.php +++ b/tests/lib/SimpleSAML/Utils/CryptoTest.php @@ -243,7 +243,6 @@ PHP; */ public function testBadHashAlgorithmValid() { - $pw = "password"; $algorithm = "wtf"; $hash = "{".$algorithm."}B64STRING"; diff --git a/tests/lib/SimpleSAML/Utils/SystemTest.php b/tests/lib/SimpleSAML/Utils/SystemTest.php index 07424e3594f79290898de7c579616361b6b5f0e8..e177a31a232454062ce55ee5e9e6f8fbd80f7e76 100644 --- a/tests/lib/SimpleSAML/Utils/SystemTest.php +++ b/tests/lib/SimpleSAML/Utils/SystemTest.php @@ -226,7 +226,7 @@ class SystemTest extends TestCase chown($tempdir, $bad_uid); $this->setExpectedException('\SimpleSAML\Error\Exception'); - $res = System::getTempDir(); + System::getTempDir(); $this->clearInstance($config, '\SimpleSAML\Configuration'); } diff --git a/tests/lib/SimpleSAML/Utils/XMLTest.php b/tests/lib/SimpleSAML/Utils/XMLTest.php index 4f820a9efa2855fe8dc1a8c625ee17a98825f175..84a01ac3cb1aad38385791cf783e9af9137f25b0 100644 --- a/tests/lib/SimpleSAML/Utils/XMLTest.php +++ b/tests/lib/SimpleSAML/Utils/XMLTest.php @@ -150,7 +150,7 @@ class XMLTest extends TestCase { $dom = new \DOMDocument(); $element = $dom->appendChild(new \DOMElement('root')); - $comment = $element->appendChild(new \DOMComment('')); + $element->appendChild(new \DOMComment('')); XML::getDOMText($element); } diff --git a/tests/modules/core/lib/Auth/Process/AttributeAddTest.php b/tests/modules/core/lib/Auth/Process/AttributeAddTest.php index deabdd3d210f596678284e80806dbac91275d422..e98a7c28c8902c439bd1a5ad23e9cbba042a6466 100644 --- a/tests/modules/core/lib/Auth/Process/AttributeAddTest.php +++ b/tests/modules/core/lib/Auth/Process/AttributeAddTest.php @@ -153,7 +153,7 @@ class Test_Core_Auth_Process_AttributeAdd extends TestCase 'test' => array('value1'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** @@ -172,6 +172,6 @@ class Test_Core_Auth_Process_AttributeAdd extends TestCase 'test' => array('value1'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } } diff --git a/tests/modules/core/lib/Auth/Process/AttributeAlterTest.php b/tests/modules/core/lib/Auth/Process/AttributeAlterTest.php index d59522cba870bb66f6ac551e7575745137c86ad5..fa292a690f27b0eda33f8a8420d71d5dcf0b82f7 100644 --- a/tests/modules/core/lib/Auth/Process/AttributeAlterTest.php +++ b/tests/modules/core/lib/Auth/Process/AttributeAlterTest.php @@ -225,7 +225,7 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase 'eduPersonAffiliation' => array('emperess', 'emperor'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** @@ -243,7 +243,7 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase 'eduPersonAffiliation' => array('emperess', 'emperor'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** @@ -258,18 +258,12 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase 'pattern' => '/wrong/', ); - $request = array( - 'Attributes' => array( - 'test' => array('somethingiswrong'), - ), - ); - $request = array( 'Attributes' => array( 'eduPersonAffiliation' => array('emperess', 'emperor'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** @@ -286,18 +280,12 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase '%remove', ); - $request = array( - 'Attributes' => array( - 'test' => array('somethingiswrong'), - ), - ); - $request = array( 'Attributes' => array( 'eduPersonAffiliation' => array('emperess', 'emperor'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** @@ -314,18 +302,12 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase '%remove', ); - $request = array( - 'Attributes' => array( - 'test' => array('somethingiswrong'), - ), - ); - $request = array( 'Attributes' => array( 'eduPersonAffiliation' => array('emperess', 'emperor'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } @@ -342,17 +324,11 @@ class Test_Core_Auth_Process_AttributeAlter extends TestCase 'replacement' => null, ); - $request = array( - 'Attributes' => array( - 'test' => array('somethingiswrong'), - ), - ); - $request = array( 'Attributes' => array( 'eduPersonAffiliation' => array('emperess', 'emperor'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } } diff --git a/tests/modules/core/lib/Auth/Process/AttributeCopyTest.php b/tests/modules/core/lib/Auth/Process/AttributeCopyTest.php index 52f03613cffebdcc1eee49bf3b4b6504d0d3aa59..dc2b7637cf3c3c485a5eace63d2e13a1cea8b2a7 100644 --- a/tests/modules/core/lib/Auth/Process/AttributeCopyTest.php +++ b/tests/modules/core/lib/Auth/Process/AttributeCopyTest.php @@ -139,7 +139,7 @@ class Test_Core_Auth_Process_AttributeCopy extends TestCase 'test' => array('value1'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** @@ -157,6 +157,6 @@ class Test_Core_Auth_Process_AttributeCopy extends TestCase 'test' => array('value1'), ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } } diff --git a/tests/modules/core/lib/Auth/Process/AttributeLimitTest.php b/tests/modules/core/lib/Auth/Process/AttributeLimitTest.php index fc55240f9f9e1b88cf71390973b06eb773346b98..0986313d2920a048d30581e35593a4cb8f1a9693 100644 --- a/tests/modules/core/lib/Auth/Process/AttributeLimitTest.php +++ b/tests/modules/core/lib/Auth/Process/AttributeLimitTest.php @@ -208,7 +208,7 @@ class Test_Core_Auth_Process_AttributeLimitTest extends TestCase 'invalidArg' => TRUE, ); - $result = self::processFilter($config, self::$request); + self::processFilter($config, self::$request); } /** @@ -222,7 +222,7 @@ class Test_Core_Auth_Process_AttributeLimitTest extends TestCase null ); - $result = self::processFilter($config, self::$request); + self::processFilter($config, self::$request); } @@ -464,7 +464,7 @@ class Test_Core_Auth_Process_AttributeLimitTest extends TestCase ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** diff --git a/tests/modules/core/lib/Auth/Process/AttributeRealmTest.php b/tests/modules/core/lib/Auth/Process/AttributeRealmTest.php index 75ea9441a31e7a4b78db68cbc45e4bea17030b0f..62f1e8586efd58fe03751b7c96a7afac304f5322 100644 --- a/tests/modules/core/lib/Auth/Process/AttributeRealmTest.php +++ b/tests/modules/core/lib/Auth/Process/AttributeRealmTest.php @@ -51,7 +51,7 @@ class Test_Core_Auth_Process_AttributeRealm extends TestCase $request = array( 'Attributes' => array(), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** diff --git a/tests/modules/core/lib/Auth/Process/TargetedIDTest.php b/tests/modules/core/lib/Auth/Process/TargetedIDTest.php index e828db7795514618ddfe422514f95d59f57344f6..15c6b764d830890defea60d9e28af6df8f57c3c8 100644 --- a/tests/modules/core/lib/Auth/Process/TargetedIDTest.php +++ b/tests/modules/core/lib/Auth/Process/TargetedIDTest.php @@ -173,7 +173,7 @@ class Test_Core_Auth_Process_TargetedID extends TestCase $request = array( 'Attributes' => array(), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** @@ -191,7 +191,7 @@ class Test_Core_Auth_Process_TargetedID extends TestCase 'displayName' => 'Jack Student', ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** @@ -209,7 +209,7 @@ class Test_Core_Auth_Process_TargetedID extends TestCase 'displayName' => 'Jack Student', ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } /** @@ -227,6 +227,6 @@ class Test_Core_Auth_Process_TargetedID extends TestCase 'displayName' => 'Jack Student', ), ); - $result = self::processFilter($config, $request); + self::processFilter($config, $request); } }