From 1c1679e12270bcc9fa3306527b053555df66484f Mon Sep 17 00:00:00 2001
From: Jaime Perez Crespo <jaime.perez@uninett.no>
Date: Wed, 27 May 2015 22:18:14 +0200
Subject: [PATCH] Fix the phpdoc for SimpleSAML\Utils\Random::generateID() and
add a constant with the length of generated IDs.
---
lib/SimpleSAML/Utils/Random.php | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/SimpleSAML/Utils/Random.php b/lib/SimpleSAML/Utils/Random.php
index fc87dcf7c..8e42a587c 100644
--- a/lib/SimpleSAML/Utils/Random.php
+++ b/lib/SimpleSAML/Utils/Random.php
@@ -10,9 +10,14 @@ class Random
{
/**
- * Generate a random identifier, 22 bytes long.
+ * The fixed length of random identifiers.
+ */
+ const ID_LENGTH = 43;
+
+ /**
+ * Generate a random identifier, ID_LENGTH bytes long.
*
- * @return string A 22-bytes long string with a random, hex string.
+ * @return string A ID_LENGTH-bytes long string with a random, hex-encoded string.
*
* @author Andreas Solberg, UNINETT AS <andreas.solberg@uninett.no>
* @author Olav Morken, UNINETT AS <olav.morken@uninett.no>
@@ -20,6 +25,6 @@ class Random
*/
public static function generateID()
{
- return '_'.bin2hex(openssl_random_pseudo_bytes(21));
+ return '_'.bin2hex(openssl_random_pseudo_bytes((self::ID_LENGTH - 1)/2));
}
}
\ No newline at end of file
--
GitLab