From 2617801fc09c60262293f15af7012ce6b2fc5692 Mon Sep 17 00:00:00 2001
From: Jon Dufresne <jon.dufresne@gmail.com>
Date: Sun, 15 May 2016 00:11:13 -0700
Subject: [PATCH] Fix PHP notices "Undefined index" in as_login.php. (#392)
Sometimes appear in error logs as:
PHP Notice: Undefined index: ReturnTo in .../modules/core/www/as_login.php on line 9
PHP Notice: Undefined index: AuthId in .../modules/core/www/as_login.php on line 13
---
modules/core/www/as_login.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules/core/www/as_login.php b/modules/core/www/as_login.php
index 9fcd6ba8a..189e05408 100644
--- a/modules/core/www/as_login.php
+++ b/modules/core/www/as_login.php
@@ -6,11 +6,11 @@
* @package SimpleSAMLphp
*/
-if (!is_string($_REQUEST['ReturnTo'])) {
+if (!isset($_REQUEST['ReturnTo'])) {
throw new SimpleSAML_Error_BadRequest('Missing ReturnTo parameter.');
}
-if (!is_string($_REQUEST['AuthId'])) {
+if (!isset($_REQUEST['AuthId'])) {
throw new SimpleSAML_Error_BadRequest('Missing AuthId parameter.');
}
--
GitLab