From 28843292c87b3ac727c97a5ce29da71112d7d634 Mon Sep 17 00:00:00 2001
From: Thijs Kinkhorst <thijs@kinkhorst.com>
Date: Tue, 20 Nov 2018 11:51:01 +0000
Subject: [PATCH] Switch assert argument order to expected, tested

---
 tests/lib/SimpleSAML/Utils/Config/MetadataTest.php | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/lib/SimpleSAML/Utils/Config/MetadataTest.php b/tests/lib/SimpleSAML/Utils/Config/MetadataTest.php
index f7aa338af..21f56b65e 100644
--- a/tests/lib/SimpleSAML/Utils/Config/MetadataTest.php
+++ b/tests/lib/SimpleSAML/Utils/Config/MetadataTest.php
@@ -268,35 +268,35 @@ class MetadataTest extends TestCase
     {
         // Test null or unset
         $nameIdPolicy = null;
-        $this->assertEquals(Metadata::parseNameIdPolicy($nameIdPolicy), ['Format' => \SAML2\Constants::NAMEID_TRANSIENT]);
+        $this->assertEquals(['Format' => \SAML2\Constants::NAMEID_TRANSIENT], Metadata::parseNameIdPolicy($nameIdPolicy));
 
         // Test false
         $nameIdPolicy = false;
-        $this->assertEquals(Metadata::parseNameIdPolicy($nameIdPolicy), null);
+        $this->assertEquals(null, Metadata::parseNameIdPolicy($nameIdPolicy));
 
         // Test string
         $nameIdPolicy = 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress';
-        $this->assertEquals(Metadata::parseNameIdPolicy($nameIdPolicy), ['Format' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress']);
+        $this->assertEquals(['Format' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress'], Metadata::parseNameIdPolicy($nameIdPolicy));
 
         // Test array
         $nameIdPolicy = [
             'Format' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:persistent',
             'AllowCreate' => false
         ];
-        $this->assertEquals(Metadata::parseNameIdPolicy($nameIdPolicy), [
+        $this->assertEquals([
             'Format' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:persistent',
             'AllowCreate' => false
-        ]);
+        ], Metadata::parseNameIdPolicy($nameIdPolicy));
 
         $nameIdPolicy = [
             'Format' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:persistent',
             'AllowCreate' => false,
             'SPNameQualifier' => 'TEST'
         ];
-        $this->assertEquals(Metadata::parseNameIdPolicy($nameIdPolicy), [
+        $this->assertEquals([
             'Format' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:persistent',
             'AllowCreate' => false,
             'SPNameQualifier' => 'TEST'
-        ]);
+        ], Metadata::parseNameIdPolicy($nameIdPolicy));
     }
 }
-- 
GitLab