From 2e10ed5edb6b8468515ef94947a07a01e13d2b17 Mon Sep 17 00:00:00 2001
From: Olav Morken <olav.morken@uninett.no>
Date: Tue, 7 Feb 2012 07:43:21 +0000
Subject: [PATCH] Fix a couple of pass-by-referece errors.
Since pass-by-reference has been removed in PHP 5.4, it should no
longer be used. Both of these places probably used it by mistake,
so removing it should be safe.
Thanks to Thijs Kinkhorst for fixing this!
git-svn-id: https://simplesamlphp.googlecode.com/svn/trunk@3029 44740490-163a-0410-bde0-09ae8108e29a
---
modules/InfoCard/lib/STS.php | 2 +-
modules/saml2debug/www/debug.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules/InfoCard/lib/STS.php b/modules/InfoCard/lib/STS.php
index 9d8d137a7..a9530efd4 100644
--- a/modules/InfoCard/lib/STS.php
+++ b/modules/InfoCard/lib/STS.php
@@ -151,7 +151,7 @@ class sspmod_InfoCard_STS {
$signature = '';
$privkey = openssl_pkey_get_private(file_get_contents($ICconfig['sts_key']));
- openssl_sign($canonicalbuf, &$signature, $privkey);
+ openssl_sign($canonicalbuf, $signature, $privkey);
openssl_free_key($privkey);
$infocard_signature = base64_encode($signature);
diff --git a/modules/saml2debug/www/debug.php b/modules/saml2debug/www/debug.php
index 0d1afa7b5..391b1b805 100644
--- a/modules/saml2debug/www/debug.php
+++ b/modules/saml2debug/www/debug.php
@@ -11,7 +11,7 @@ function getValue($raw) {
if (!empty($url)) $val = $url;
$arr = array();
- $query = parse_str($val, &$arr);
+ $query = parse_str($val, $arr);
#echo('<pre>');print_r($arr);
--
GitLab