From 318709e68aaef7a74fae40370908eeb2ad77e3b8 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Tue, 15 Mar 2022 17:07:41 +0100
Subject: [PATCH] Address some of the comments
---
lib/SimpleSAML/Metadata/Sources/MDQ.php | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/lib/SimpleSAML/Metadata/Sources/MDQ.php b/lib/SimpleSAML/Metadata/Sources/MDQ.php
index d96f882d5..7b99ced91 100644
--- a/lib/SimpleSAML/Metadata/Sources/MDQ.php
+++ b/lib/SimpleSAML/Metadata/Sources/MDQ.php
@@ -149,7 +149,7 @@ class MDQ extends MetaDataStorageSource
return null;
}
- $file = new file($cacheFileName);
+ $file = new File($cacheFileName);
if (!$file->isReadable()) {
throw new Exception(sprintf('%s: could not read cache file for entity [%s]', strval($file), __CLASS__));
}
@@ -208,11 +208,8 @@ class MDQ extends MetaDataStorageSource
$cacheFileName = $this->getCacheFilename($set, $entityId);
$file = new File($cacheFileName);
- if (!$file->isWritable()) {
- throw new Exception(sprintf('%s: could not write cache file for entity [%s]', __CLASS__, strval($file)));
- }
- Logger::debug(sprintf('%s: Writing cache [%s] => [%s]', __CLASS__, $entityId, strval($file)));
+ Logger::debug(sprintf('%s: Writing cache [%s] => [%s]', __CLASS__, $entityId, strval($file)));
$this->fileSystem->appendToFile(strval($file), serialize($data), true);
}
--
GitLab