From 31dc7ea733af37144acf7599e79485f415c6c5c2 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Thu, 4 Jan 2018 18:45:16 +0100
Subject: [PATCH] Phpdoc
---
lib/SimpleSAML/XML/Signer.php | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/lib/SimpleSAML/XML/Signer.php b/lib/SimpleSAML/XML/Signer.php
index f84a33544..e4a04e05a 100644
--- a/lib/SimpleSAML/XML/Signer.php
+++ b/lib/SimpleSAML/XML/Signer.php
@@ -20,28 +20,26 @@ use SimpleSAML\Utils\Config;
class Signer
{
-
-
/**
* @var string The name of the ID attribute.
*/
- private $idAttrName;
+ private $idAttrName = '';
/**
* @var XMLSecurityKey|bool The private key (as an XMLSecurityKey).
*/
- private $privateKey;
+ private $privateKey = false;
/**
- * @var string The certificate (as text).
+ * @var string|bool The certificate (as text).
*/
- private $certificate;
+ private $certificate = false;
/**
* @var array Extra certificates which should be included in the response.
*/
- private $extraCertificates;
+ private $extraCertificates = array();
/**
@@ -64,11 +62,6 @@ class Signer
{
assert(is_array($options));
- $this->idAttrName = false;
- $this->privateKey = false;
- $this->certificate = false;
- $this->extraCertificates = array();
-
if (array_key_exists('privatekey', $options)) {
$pass = null;
if (array_key_exists('privatekey_pass', $options)) {
@@ -291,7 +284,7 @@ class Signer
$objXMLSecDSig->setCanonicalMethod(XMLSecurityDSig::EXC_C14N);
$options = array();
- if ($this->idAttrName !== false) {
+ if (!empty($this->idAttrName)) {
$options['id_name'] = $this->idAttrName;
}
--
GitLab