From 36a883ec19d2913e0f46268fca01aa5dab412a93 Mon Sep 17 00:00:00 2001
From: Thijs Kinkhorst <thijs@kinkhorst.com>
Date: Wed, 24 Apr 2019 18:19:10 +0000
Subject: [PATCH] Avoid PHP notices for remote SP entries without keys
---
modules/admin/lib/FederationController.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules/admin/lib/FederationController.php b/modules/admin/lib/FederationController.php
index 5680c2cc8..0f7ac4ca9 100644
--- a/modules/admin/lib/FederationController.php
+++ b/modules/admin/lib/FederationController.php
@@ -330,8 +330,8 @@ class FederationController
/** @var \SimpleSAML\Module\saml\Auth\Source\SP $source */
foreach (\SimpleSAML\Auth\Source::getSourcesOfType('saml:SP') as $source) {
$metadata = $source->getHostedMetadata();
- $certificates = $metadata['keys'];
- if (count($metadata['keys']) === 1) {
+ $certificates = $metadata['keys'] ?? [];
+ if (count($certificates) === 1) {
$cert = array_pop($metadata['keys']);
$metadata['certData'] = $cert['X509Certificate'];
unset($metadata['keys']);
--
GitLab