diff --git a/modules/cron/hooks/hook_configpage.php b/modules/cron/hooks/hook_configpage.php index dc3c8400b7169e66c4b4cd97756e1a0cbeccca4e..136888a0036582a91a086acf69179db53fa81fce 100644 --- a/modules/cron/hooks/hook_configpage.php +++ b/modules/cron/hooks/hook_configpage.php @@ -1,10 +1,11 @@ <?php + /** * Hook to add the cron module to the config page. * * @param \SimpleSAML\XHTML\Template &$template The template that we should alter in this hook. + * @return void */ - function cron_hook_configpage(\SimpleSAML\XHTML\Template &$template) { $template->data['links']['cron'] = [ diff --git a/modules/cron/hooks/hook_cron.php b/modules/cron/hooks/hook_cron.php index 61812906a2e8fee62ba13e042314d827ca36f39d..eb4718275f11e04da59d7f5f8c0b4e292f0ec3ec 100644 --- a/modules/cron/hooks/hook_cron.php +++ b/modules/cron/hooks/hook_cron.php @@ -1,10 +1,11 @@ <?php + /** * Hook to run a cron job. * * @param array &$croninfo Output + * @return void */ - function cron_hook_cron(&$croninfo) { assert(is_array($croninfo)); diff --git a/modules/cron/hooks/hook_frontpage.php b/modules/cron/hooks/hook_frontpage.php index 73fcd215b74521dfb827f505f5896ec49a47de39..9a0401a275bb7dab7987008b725f7dc6a20e730e 100644 --- a/modules/cron/hooks/hook_frontpage.php +++ b/modules/cron/hooks/hook_frontpage.php @@ -1,10 +1,11 @@ <?php + /** * Hook to add the modinfo module to the frontpage. * * @param array &$links The links on the frontpage, split into sections. + * @return void */ - function cron_hook_frontpage(&$links) { assert(is_array($links)); diff --git a/modules/cron/lib/Cron.php b/modules/cron/lib/Cron.php index f8bda653b8b23b4dc6061668160c453e8044ba13..5396a2cfe0762221ccac7836b6c90718bb16b1cd 100644 --- a/modules/cron/lib/Cron.php +++ b/modules/cron/lib/Cron.php @@ -1,6 +1,6 @@ <?php -namespace SimpleSAML\Module\cron; +namespace SimpleSAML\Module\cron; /** * Handles interactions with SSP's cron system/hooks. @@ -27,13 +27,12 @@ class Cron /** * Invoke the cron hook for the given tag - * @param $tag string The tag to use. Must be valid in the cronConfig + * @param string $tag The tag to use. Must be valid in the cronConfig * @return array the tag, and summary information from the run. * @throws Exception If an invalid tag specified */ public function runTag($tag) { - if (!$this->isValidTag($tag)) { throw new \Exception("Invalid cron tag '$tag''"); } @@ -53,6 +52,10 @@ class Cron return $croninfo; } + /** + * @param string $tag + * @return bool + */ public function isValidTag($tag) { if (!is_null($this->cronconfig->getValue('allowed_tags'))) {