From 50a63b571f4c6dacb035673288d8875c80475d09 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Sun, 3 Feb 2019 20:12:15 +0100
Subject: [PATCH] Fixes for modules/authtwitter
---
modules/authtwitter/lib/Auth/Source/Twitter.php | 6 ++++++
modules/authtwitter/www/linkback.php | 1 +
2 files changed, 7 insertions(+)
diff --git a/modules/authtwitter/lib/Auth/Source/Twitter.php b/modules/authtwitter/lib/Auth/Source/Twitter.php
index 19ff72580..6a0a03e99 100644
--- a/modules/authtwitter/lib/Auth/Source/Twitter.php
+++ b/modules/authtwitter/lib/Auth/Source/Twitter.php
@@ -72,6 +72,7 @@ class Twitter extends \SimpleSAML\Auth\Source
* Log-in using Twitter platform
*
* @param array &$state Information about the current authentication.
+ * @return void
*/
public function authenticate(&$state)
{
@@ -103,6 +104,11 @@ class Twitter extends \SimpleSAML\Auth\Source
$consumer->getAuthorizeRequest($url, $requestToken);
}
+
+ /**
+ * @param array &$state
+ * @return void
+ */
public function finalStep(&$state)
{
$requestToken = $state['authtwitter:authdata:requestToken'];
diff --git a/modules/authtwitter/www/linkback.php b/modules/authtwitter/www/linkback.php
index cbeed68a7..78c0382a4 100644
--- a/modules/authtwitter/www/linkback.php
+++ b/modules/authtwitter/www/linkback.php
@@ -20,6 +20,7 @@ if (!array_key_exists(\SimpleSAML\Module\authtwitter\Auth\Source\Twitter::AUTHID
}
$sourceId = $state[\SimpleSAML\Module\authtwitter\Auth\Source\Twitter::AUTHID];
+/** @var \SimpleSAML\Module\authtwitter\Auth\Source\Twitter|null $source */
$source = \SimpleSAML\Auth\Source::getById($sourceId);
if ($source === null) {
throw new \SimpleSAML\Error\BadRequest(
--
GitLab