From 76008e8fc116a70d71565a5535c933d4b6a96836 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tim.dijen@minbzk.nl>
Date: Mon, 29 Jul 2019 20:21:41 +0200
Subject: [PATCH] Annotation and whitespace
---
modules/admin/lib/FederationController.php | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/modules/admin/lib/FederationController.php b/modules/admin/lib/FederationController.php
index cc9beba33..c031c68bf 100644
--- a/modules/admin/lib/FederationController.php
+++ b/modules/admin/lib/FederationController.php
@@ -467,12 +467,16 @@ class FederationController
$prefix = $request->get('prefix');
if ($set === 'saml20-sp-hosted') {
- $sourceID = $request->get('source');
- $source = \SimpleSAML\Auth\Source::getById($sourceID, Module\saml\Auth\Source\SP::class);
- $mdconfig = $source->getMetadata();
+ $sourceID = $request->get('source');
+ /**
+ * The second argument ensures non-nullable return-value
+ * @var \SimpleSAML\Module\saml\Auth\Source\SP $source
+ */
+ $source = \SimpleSAML\Auth\Source::getById($sourceID, Module\saml\Auth\Source\SP::class);
+ $mdconfig = $source->getMetadata();
} else {
- $entityID = $request->get('entity');
- $mdconfig = $this->mdHandler->getMetaDataConfig($entityID, $set);
+ $entityID = $request->get('entity');
+ $mdconfig = $this->mdHandler->getMetaDataConfig($entityID, $set);
}
$certInfo = Utils\Crypto::loadPublicKey($mdconfig, true, $prefix);
--
GitLab