From 7f6df92faad4d7293bf2cf4fb426e99e56a2447b Mon Sep 17 00:00:00 2001
From: Brian Vuyk <brian@brianvuyk.com>
Date: Tue, 12 May 2015 10:46:05 -0400
Subject: [PATCH] Use !in_array() for improved readability
---
modules/saml/lib/Message.php | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/modules/saml/lib/Message.php b/modules/saml/lib/Message.php
index a8bc8163d..da841b5bb 100644
--- a/modules/saml/lib/Message.php
+++ b/modules/saml/lib/Message.php
@@ -587,8 +587,9 @@ class sspmod_saml_Message {
$found = FALSE;
$lastError = 'No SubjectConfirmation element in Subject.';
+ $validSCMethods = array(SAML2_Const::CM_BEARER, SAML2_Const::CM_HOK, SAML2_Const::CM_VOUCHES);
foreach ($assertion->getSubjectConfirmation() as $sc) {
- if ($sc->Method !== SAML2_Const::CM_BEARER && $sc->Method !== SAML2_Const::CM_HOK && $sc->Method !== SAML2_Const::CM_VOUCHES) {
+ if (!in_array($sc->Method, $validSCMethods)) {
$lastError = 'Invalid Method on SubjectConfirmation: ' . var_export($sc->Method, TRUE);
continue;
}
--
GitLab