From 8239f34bd819f46a243807badef55e783362c810 Mon Sep 17 00:00:00 2001
From: Gabriel Caruso <carusogabriel34@gmail.com>
Date: Wed, 29 Nov 2017 01:33:38 -0200
Subject: [PATCH] Refactoring tests
---
tests/lib/SimpleSAML/Store/SQLTest.php | 10 +++++-----
tests/lib/SimpleSAML/StoreTest.php | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/lib/SimpleSAML/Store/SQLTest.php b/tests/lib/SimpleSAML/Store/SQLTest.php
index 09b4ddbf5..56f21156a 100644
--- a/tests/lib/SimpleSAML/Store/SQLTest.php
+++ b/tests/lib/SimpleSAML/Store/SQLTest.php
@@ -93,7 +93,7 @@ class SQLTest extends \PHPUnit_Framework_TestCase
$value = $store->get('test', 'foo');
- $this->assertEquals(null, $value);
+ $this->assertNull($value);
}
/**
@@ -106,10 +106,10 @@ class SQLTest extends \PHPUnit_Framework_TestCase
{
/** @var \SimpleSAML\Store\SQL $store */
$store = Store::getInstance();
-
+
$store->set('test', 'foo', 'bar');
$value = $store->get('test', 'foo');
-
+
$this->assertEquals('bar', $value);
}
@@ -147,7 +147,7 @@ class SQLTest extends \PHPUnit_Framework_TestCase
$store->delete('test', 'foo');
$value = $store->get('test', 'foo');
- $this->assertEquals(null, $value);
+ $this->assertNull($value);
}
/**
@@ -167,7 +167,7 @@ class SQLTest extends \PHPUnit_Framework_TestCase
$store->delete('test', $key);
$value = $store->get('test', $key);
- $this->assertEquals(null, $value);
+ $this->assertNull($value);
}
protected function tearDown()
diff --git a/tests/lib/SimpleSAML/StoreTest.php b/tests/lib/SimpleSAML/StoreTest.php
index 6fd9650fc..e807d5c84 100644
--- a/tests/lib/SimpleSAML/StoreTest.php
+++ b/tests/lib/SimpleSAML/StoreTest.php
@@ -27,7 +27,7 @@ class StoreTest extends \PHPUnit_Framework_TestCase
$store = Store::getInstance();
- $this->assertEquals(false, $store);
+ $this->assertFalse($store);
}
@@ -42,7 +42,7 @@ class StoreTest extends \PHPUnit_Framework_TestCase
$store = Store::getInstance();
- $this->assertEquals(false, $store);
+ $this->assertFalse($store);
}
--
GitLab