From 83f90ed3033b05a766f987f03f2fb752cf851577 Mon Sep 17 00:00:00 2001
From: Thijs Kinkhorst <thijs@kinkhorst.com>
Date: Fri, 14 Jan 2022 14:08:46 +0000
Subject: [PATCH] Some small HTML fixes

---
 modules/admin/templates/federation.twig | 4 ++--
 templates/_footer.twig                  | 4 ++--
 templates/_header.twig                  | 4 ++--
 templates/auth_status.twig              | 3 ++-
 templates/base.twig                     | 2 ++
 5 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/modules/admin/templates/federation.twig b/modules/admin/templates/federation.twig
index d44d885ff..ccc3c752f 100644
--- a/modules/admin/templates/federation.twig
+++ b/modules/admin/templates/federation.twig
@@ -128,7 +128,7 @@
     <form action="{{ moduleURL('admin/federation/show') }}" method="get" class="pure-form">
       <fieldset class="fancyfieldset">
         <legend>{% trans %}Look up metadata for entity:{% endtrans %}</legend>
-        <select name="set">
+        <select name="set" aria-labelledby="lookupbutton">
           {%- if entries.remote %}
             {%- for key, set in entries.remote %}
 
@@ -138,7 +138,7 @@
 
         </select>
         <input type="text" name="entityid" placeholder="{% trans %}EntityID{% endtrans %}">
-        <button class="pure-button pure-button-red" type="submit">{% trans %}Search{% endtrans %}</button>
+        <button class="pure-button pure-button-red" type="submit" id="lookupbutton">{% trans %}Search{% endtrans %}</button>
       </fieldset>
     </form>
 {% endblock %}
diff --git a/templates/_footer.twig b/templates/_footer.twig
index 7a6705b9c..45b630fa3 100644
--- a/templates/_footer.twig
+++ b/templates/_footer.twig
@@ -1,4 +1,4 @@
-<div id="footer">
+<footer id="footer">
   <div class="wrap">
     <div class="center copyrights">&copy; 2007-{{ year }} <a href="https://simplesamlphp.org/">SimpleSAMLphp</a>
     </div>
@@ -8,4 +8,4 @@
       </div>
     </div>
   </div>
-</div>
+</footer>
diff --git a/templates/_header.twig b/templates/_header.twig
index 76c877b49..fc3a47355 100644
--- a/templates/_header.twig
+++ b/templates/_header.twig
@@ -1,4 +1,4 @@
-<div id="header">
+<header id="header">
   <div class="wrap">
     <div class="left">
       <div class="v-center logo-header">
@@ -75,5 +75,5 @@
       </div>{# language bar #}
     </div>{# show-for-large #}
   </div>{# wrap #}
-</div>{# header #}
+</header>
 
diff --git a/templates/auth_status.twig b/templates/auth_status.twig
index 5ba1be20a..731ef1f87 100644
--- a/templates/auth_status.twig
+++ b/templates/auth_status.twig
@@ -71,7 +71,7 @@
 
     <dl>
       <dt>{% trans %}Debug information to be used by your support staff{% endtrans %}</dt>
-      {%- embed "includes/expander.twig" %}
+      <dd>{%- embed "includes/expander.twig" %}
         {%- block content %}
 
         <dl>
@@ -101,6 +101,7 @@
         {%- endblock content %}
       {%- endembed %}
 
+     </dd>
     </dl>
     <br>
 
diff --git a/templates/base.twig b/templates/base.twig
index 5c115e9fe..31b96a99f 100644
--- a/templates/base.twig
+++ b/templates/base.twig
@@ -17,12 +17,14 @@
   <body id="{{ templateId }}">
     <div id="layout">
     {% block header %}{% include "_header.twig" %}{% endblock %}
+      <main>
       <div id="content">
         <div class="wrap">
           {% block contentwrapper %}{% block content %}{% endblock %}{% endblock contentwrapper %}
         </div>
       </div>{# content #}
       <div id="push"></div>
+      </main>
     </div>{# layout #}
     <div id="foot">
       {% block footer %}{% include "_footer.twig" %}{% endblock %}
-- 
GitLab