From 8717d34d2b39abbdf33dc94ae5858092fcdfd784 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Sun, 18 Aug 2019 16:19:14 +0200
Subject: [PATCH] Add deprecation note on SAML1.1 / Shibboleth 1.3
---
docs/simplesamlphp-changelog.md | 1 +
lib/SimpleSAML/Bindings/Shib13/Artifact.php | 1 +
lib/SimpleSAML/Bindings/Shib13/HTTPPost.php | 1 +
lib/SimpleSAML/XML/Shib13/AuthnRequest.php | 1 +
lib/SimpleSAML/XML/Shib13/AuthnResponse.php | 1 +
modules/saml/lib/IdP/SAML1.php | 1 +
tests/lib/SimpleSAML/XML/Shib13/AuthnResponseTest.php | 1 +
7 files changed, 7 insertions(+)
diff --git a/docs/simplesamlphp-changelog.md b/docs/simplesamlphp-changelog.md
index 675cb9a8d..019956b44 100644
--- a/docs/simplesamlphp-changelog.md
+++ b/docs/simplesamlphp-changelog.md
@@ -33,6 +33,7 @@ Released TBD
* The minimum PHP version required is now 5.6.
### Deprecation
+ * Support for SAML1.1 / Shibboleth 1.3 will be discontinued in a future release
* The class SimpleSAML\Auth\TimeLimitedToken is now deprecated and will be removed in a future release
If your custom module relies on this class, be sure to make a copy into your repository and
make sure to also copy the unit tests that come along.
diff --git a/lib/SimpleSAML/Bindings/Shib13/Artifact.php b/lib/SimpleSAML/Bindings/Shib13/Artifact.php
index 839271f62..09703ec99 100644
--- a/lib/SimpleSAML/Bindings/Shib13/Artifact.php
+++ b/lib/SimpleSAML/Bindings/Shib13/Artifact.php
@@ -4,6 +4,7 @@
* Implementation of the Shibboleth 1.3 Artifact binding.
*
* @package SimpleSAMLphp
+ * @deprecated This class will be removed in a future release
*/
namespace SimpleSAML\Bindings\Shib13;
diff --git a/lib/SimpleSAML/Bindings/Shib13/HTTPPost.php b/lib/SimpleSAML/Bindings/Shib13/HTTPPost.php
index b98f34c3e..d7c38700a 100644
--- a/lib/SimpleSAML/Bindings/Shib13/HTTPPost.php
+++ b/lib/SimpleSAML/Bindings/Shib13/HTTPPost.php
@@ -6,6 +6,7 @@
*
* @author Andreas Ă…kre Solberg, UNINETT AS. <andreas.solberg@uninett.no>
* @package SimpleSAMLphp
+ * @deprecated This class will be removed in a future release
*/
namespace SimpleSAML\Bindings\Shib13;
diff --git a/lib/SimpleSAML/XML/Shib13/AuthnRequest.php b/lib/SimpleSAML/XML/Shib13/AuthnRequest.php
index 942dabb38..4289a82de 100644
--- a/lib/SimpleSAML/XML/Shib13/AuthnRequest.php
+++ b/lib/SimpleSAML/XML/Shib13/AuthnRequest.php
@@ -6,6 +6,7 @@
*
* @author Andreas Ă…kre Solberg, UNINETT AS. <andreas.solberg@uninett.no>
* @package SimpleSAMLphp
+ * @deprecated This class will be removed in a future release
*/
namespace SimpleSAML\XML\Shib13;
diff --git a/lib/SimpleSAML/XML/Shib13/AuthnResponse.php b/lib/SimpleSAML/XML/Shib13/AuthnResponse.php
index 9148c3869..69b798f54 100644
--- a/lib/SimpleSAML/XML/Shib13/AuthnResponse.php
+++ b/lib/SimpleSAML/XML/Shib13/AuthnResponse.php
@@ -5,6 +5,7 @@
*
* @author Andreas Ă…kre Solberg, UNINETT AS. <andreas.solberg@uninett.no>
* @package SimpleSAMLphp
+ * @deprecated This class will be removed in a future release
*/
namespace SimpleSAML\XML\Shib13;
diff --git a/modules/saml/lib/IdP/SAML1.php b/modules/saml/lib/IdP/SAML1.php
index 0cb5cf5ea..d0a3d8c9a 100644
--- a/modules/saml/lib/IdP/SAML1.php
+++ b/modules/saml/lib/IdP/SAML1.php
@@ -17,6 +17,7 @@ use SimpleSAML\XML\Shib13\AuthnResponse;
* IdP implementation for SAML 1.1 protocol.
*
* @package SimpleSAMLphp
+ * @deprecated This class will be removed in a future release
*/
class SAML1
{
diff --git a/tests/lib/SimpleSAML/XML/Shib13/AuthnResponseTest.php b/tests/lib/SimpleSAML/XML/Shib13/AuthnResponseTest.php
index 764b2f350..75f992f62 100644
--- a/tests/lib/SimpleSAML/XML/Shib13/AuthnResponseTest.php
+++ b/tests/lib/SimpleSAML/XML/Shib13/AuthnResponseTest.php
@@ -6,6 +6,7 @@
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
+ * @deprecated This class will be removed in a future release
*/
--
GitLab