From 897e2a7d8a2f99be2c6cdbce24c5e340bdc9d472 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Tue, 9 Jul 2019 22:37:39 +0200
Subject: [PATCH] Fix Psalm-issues in SessionHandlerPHP.php
---
lib/SimpleSAML/SessionHandlerPHP.php | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/SimpleSAML/SessionHandlerPHP.php b/lib/SimpleSAML/SessionHandlerPHP.php
index 7d320a275..a1bff138d 100644
--- a/lib/SimpleSAML/SessionHandlerPHP.php
+++ b/lib/SimpleSAML/SessionHandlerPHP.php
@@ -168,6 +168,10 @@ class SessionHandlerPHP extends SessionHandler
if (($sid_length * $sid_bits_per_char) < 128) {
Logger::warning("Unsafe defaults used for sessionId generation!");
}
+ /**
+ * This annotation may be removed as soon as we start using vimeo/psalm 3.x
+ * @psalm-suppress TooFewArguments
+ */
$sessionId = session_create_id();
} else {
$sessionId = bin2hex(openssl_random_pseudo_bytes(16));
@@ -364,7 +368,7 @@ class SessionHandlerPHP extends SessionHandler
);
}
- session_id($sessionID);
+ session_id(strval($sessionID));
@session_start();
}
}
--
GitLab