diff --git a/lib/SimpleSAML/SessionHandlerPHP.php b/lib/SimpleSAML/SessionHandlerPHP.php index 11a3dbd3a2e86d85da0d4f3d713f1e987cc1f54a..c857df02756edb20c7444e42867c1c0d80a135b1 100644 --- a/lib/SimpleSAML/SessionHandlerPHP.php +++ b/lib/SimpleSAML/SessionHandlerPHP.php @@ -164,19 +164,24 @@ class SessionHandlerPHP extends SessionHandler */ public function newSessionId() { + $sessionId = false; + // generate new (secure) session id - $sid_length = (int) ini_get('session.sid_length'); - $sid_bits_per_char = (int) ini_get('session.sid_bits_per_character'); + if (function_exists('session_create_id')) { + $sid_length = (int) ini_get('session.sid_length'); + $sid_bits_per_char = (int) ini_get('session.sid_bits_per_character'); - if (($sid_length * $sid_bits_per_char) < 128) { - Logger::warning("Unsafe defaults used for sessionId generation!"); + if (($sid_length * $sid_bits_per_char) < 128) { + Logger::warning("Unsafe defaults used for sessionId generation!"); + } + $sessionId = session_create_id(); } - $sessionId = session_create_id(); if (!$sessionId) { Logger::warning("Secure session ID generation failed, falling back to custom ID generation."); $sessionId = bin2hex(openssl_random_pseudo_bytes(16)); } + Session::createSession($sessionId); return $sessionId; }