From aa4a29ea678641dc0818958f808db606a2b4b71c Mon Sep 17 00:00:00 2001
From: Thijs Kinkhorst <thijs@kinkhorst.com>
Date: Fri, 21 Jan 2022 15:04:17 +0000
Subject: [PATCH] Make select submit on change and label it for a11y
---
modules/core/templates/loginuserpass.twig | 2 +-
src/js/bundle.js | 4 ++++
templates/_header.twig | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/modules/core/templates/loginuserpass.twig b/modules/core/templates/loginuserpass.twig
index 07fec8577..ded4fec7f 100644
--- a/modules/core/templates/loginuserpass.twig
+++ b/modules/core/templates/loginuserpass.twig
@@ -76,7 +76,7 @@
<div class="pure-control-group">
<label for="organization">{{ 'Organization'|trans }}</label>
<div class="pure-select right pure-input-1-2 pure-input-sm-1-1">
- <select name="organization" class="" id="organization" tabindex="3">
+ <select name="organization" id="organization" tabindex="3">
{{ selectedOrg ?: null }}
{%- for id, orgDesc in organizations -%}
{% if id == selectedOrg -%}
diff --git a/src/js/bundle.js b/src/js/bundle.js
index 26610f8e6..2025d3916 100644
--- a/src/js/bundle.js
+++ b/src/js/bundle.js
@@ -6,6 +6,10 @@ import php from "highlight.js/lib/languages/php";
import json from "highlight.js/lib/languages/json";
$(document).ready(function () {
+ $('#language-selector').on('change', function () {
+ $("#language-form").submit();
+ });
+
// side menu
$('#menuLink').click(function (e) {
e.preventDefault();
diff --git a/templates/_header.twig b/templates/_header.twig
index 9b241bf4c..f3533434b 100644
--- a/templates/_header.twig
+++ b/templates/_header.twig
@@ -55,7 +55,7 @@
<input type="hidden" name="{{ name }}">
{% endif %}
{% endfor %}
- <select class="pure-input-1-4 language-menu" name="language" id="language-selector">
+ <select aria-label="{% trans %}Language{% endtrans %}" class="pure-input-1-4 language-menu" name="language" id="language-selector">
{% for key, lang in languageBar %}
{% if key == currentLanguage %}
<option value="{{ key }}" selected="selected"> {{ lang.name }}</option>
--
GitLab