From ab7303e0895ea4470d5457f46c38832b02571007 Mon Sep 17 00:00:00 2001 From: Tim van Dijen <tvdijen@gmail.com> Date: Sat, 2 Feb 2019 20:06:44 +0100 Subject: [PATCH] Fixes for lib/SimpleSAML/Bindings --- lib/SimpleSAML/Bindings/Shib13/Artifact.php | 2 +- lib/SimpleSAML/Bindings/Shib13/HTTPPost.php | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/SimpleSAML/Bindings/Shib13/Artifact.php b/lib/SimpleSAML/Bindings/Shib13/Artifact.php index 3ce30d977..30d7d130b 100644 --- a/lib/SimpleSAML/Bindings/Shib13/Artifact.php +++ b/lib/SimpleSAML/Bindings/Shib13/Artifact.php @@ -181,8 +181,8 @@ class Artifact ]; // Fetch the artifact - $response = HTTP::fetch($url, $opts); /** @var string $response */ + $response = HTTP::fetch($url, $opts); XML::debugSAMLMessage($response, 'in'); // Find the response in the SOAP message diff --git a/lib/SimpleSAML/Bindings/Shib13/HTTPPost.php b/lib/SimpleSAML/Bindings/Shib13/HTTPPost.php index 893682c1b..bc1a4b04f 100644 --- a/lib/SimpleSAML/Bindings/Shib13/HTTPPost.php +++ b/lib/SimpleSAML/Bindings/Shib13/HTTPPost.php @@ -20,12 +20,12 @@ use SimpleSAML\XML\Signer; class HTTPPost { /** - * @var \SimpleSAML\Configuration + * @var \SimpleSAML\Configuration|null */ private $configuration = null; /** - * @var \SimpleSAML\Metadata\MetaDataStorageHandler + * @var \SimpleSAML\Metadata\MetaDataStorageHandler|null */ private $metadata = null; @@ -53,6 +53,7 @@ class HTTPPost * @param \SimpleSAML\Configuration $spmd The metadata of the SP which is receiving the response. * @param string|null $relayState The relaystate for the SP. * @param string $shire The shire which should receive the response. + * @return void */ public function sendResponse( $response, -- GitLab