From b701898dfcfa62b7f7ce2662dd1520635947aa70 Mon Sep 17 00:00:00 2001
From: Thijs Kinkhorst <thijs@kinkhorst.com>
Date: Tue, 26 Mar 2019 19:12:39 +0000
Subject: [PATCH] Revert the name of EXCEPTION_PARAM to name without ".".
Because it's used in the _REQUEST array, the name is changed by PHP
to replacethe dot with an underscore, leading it not to match, that
in turn breaking the exception handling.
Thanks pverbaan for reporting this issue.
Closes: #1077
---
lib/SimpleSAML/Auth/State.php | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/SimpleSAML/Auth/State.php b/lib/SimpleSAML/Auth/State.php
index 48a5cfea6..9a3efc4cc 100644
--- a/lib/SimpleSAML/Auth/State.php
+++ b/lib/SimpleSAML/Auth/State.php
@@ -83,8 +83,10 @@ class State
/**
* The URL parameter which contains the exception state id.
+ * Note that this does not contain a "." since it's used in the
+ * _REQUEST superglobal that does not allow dots.
*/
- const EXCEPTION_PARAM = '\SimpleSAML\Auth\State.exceptionId';
+ const EXCEPTION_PARAM = '\SimpleSAML\Auth\State_exceptionId';
/**
--
GitLab