From bb6ce9f7c537c406b66cc2230d6b29644979d4a3 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Sun, 29 Jan 2017 13:04:28 +0100
Subject: [PATCH] Raise exception when memcache-server is down
The exception was never raised because $stats will be array(false) on failure instead of just false.
---
lib/SimpleSAML/Memcache.php | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/SimpleSAML/Memcache.php b/lib/SimpleSAML/Memcache.php
index a7caceb4a..199833d9f 100644
--- a/lib/SimpleSAML/Memcache.php
+++ b/lib/SimpleSAML/Memcache.php
@@ -439,8 +439,10 @@ class SimpleSAML_Memcache
foreach (self::getMemcacheServers() as $sg) {
$stats = $sg->getExtendedStats();
- if ($stats === false) {
- throw new Exception('Failed to get memcache server status.');
+ foreach ($stats as $server => $data) {
+ if ($data === false) {
+ throw new Exception('Failed to get memcache server status.');
+ }
}
$stats = SimpleSAML\Utils\Arrays::transpose($stats);
--
GitLab