From bd59154e17f730d7108fd03b00b7d0e6a6f882dc Mon Sep 17 00:00:00 2001
From: Thijs Kinkhorst <thijs@kinkhorst.com>
Date: Fri, 14 Aug 2015 16:27:19 +0000
Subject: [PATCH] Remove unreachable exception: array key is always int or
string
---
.../core/lib/Auth/Process/AttributeAdd.php | 4 ----
.../lib/Auth/Process/AttributeAddTest.php | 19 -------------------
2 files changed, 23 deletions(-)
diff --git a/modules/core/lib/Auth/Process/AttributeAdd.php b/modules/core/lib/Auth/Process/AttributeAdd.php
index fd3828a69..eeb6102f3 100644
--- a/modules/core/lib/Auth/Process/AttributeAdd.php
+++ b/modules/core/lib/Auth/Process/AttributeAdd.php
@@ -45,10 +45,6 @@ class sspmod_core_Auth_Process_AttributeAdd extends SimpleSAML_Auth_ProcessingFi
continue;
}
- if(!is_string($name)) {
- throw new Exception('Invalid attribute name: ' . var_export($name, TRUE));
- }
-
if(!is_array($values)) {
$values = array($values);
}
diff --git a/tests/modules/core/lib/Auth/Process/AttributeAddTest.php b/tests/modules/core/lib/Auth/Process/AttributeAddTest.php
index 3db1f388d..29e900db7 100644
--- a/tests/modules/core/lib/Auth/Process/AttributeAddTest.php
+++ b/tests/modules/core/lib/Auth/Process/AttributeAddTest.php
@@ -154,25 +154,6 @@ class Test_Core_Auth_Process_AttributeAdd extends PHPUnit_Framework_TestCase
$result = self::processFilter($config, $request);
}
- /**
- * Test wrong attribute name
- *
- * @expectedException Exception
- */
- public function testWrongAttributeName()
- {
- $config = array(
- '%replace',
- true => array('value2'),
- );
- $request = array(
- 'Attributes' => array(
- 'test' => array('value1'),
- ),
- );
- $result = self::processFilter($config, $request);
- }
-
/**
* Test wrong attribute value
*
--
GitLab