From c0ea93b52a77dacdbbb03140ee3121137d537e89 Mon Sep 17 00:00:00 2001 From: Tim van Dijen <tvdijen@gmail.com> Date: Fri, 27 Aug 2021 23:53:51 +0200 Subject: [PATCH] fix redirect authproc --- modules/exampleauth/lib/Controller/ExampleAuth.php | 2 +- modules/exampleauth/routing/routes/routes.yml | 6 +++--- .../exampleauth/lib/Controller/ExampleAuthTest.php | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/modules/exampleauth/lib/Controller/ExampleAuth.php b/modules/exampleauth/lib/Controller/ExampleAuth.php index bcbee53b2..0072a1a66 100644 --- a/modules/exampleauth/lib/Controller/ExampleAuth.php +++ b/modules/exampleauth/lib/Controller/ExampleAuth.php @@ -175,7 +175,7 @@ class ExampleAuth * * @return \SimpleSAML\HTTP\RunnableResponse */ - public function redirect(Request $request): RunnableResponse + public function redirecttest(Request $request): RunnableResponse { /** * Request handler for redirect filter test. diff --git a/modules/exampleauth/routing/routes/routes.yml b/modules/exampleauth/routing/routes/routes.yml index 6d65e704e..a4b52108f 100644 --- a/modules/exampleauth/routing/routes/routes.yml +++ b/modules/exampleauth/routing/routes/routes.yml @@ -1,9 +1,9 @@ exampleauth-authpage: path: /authpage defaults: { _controller: 'SimpleSAML\Module\exampleauth\Controller\ExampleAuth::authpage' } -exampleauth-redirect: - path: /redirect - defaults: { _controller: 'SimpleSAML\Module\exampleauth\Controller\ExampleAuth::redirect' } +exampleauth-redirecttest: + path: /redirecttest + defaults: { _controller: 'SimpleSAML\Module\exampleauth\Controller\ExampleAuth::redirecttest' } exampleauth-resume: path: /resume defaults: { _controller: 'SimpleSAML\Module\exampleauth\Controller\ExampleAuth::resume' } diff --git a/tests/modules/exampleauth/lib/Controller/ExampleAuthTest.php b/tests/modules/exampleauth/lib/Controller/ExampleAuthTest.php index 44860436d..3772184d9 100644 --- a/tests/modules/exampleauth/lib/Controller/ExampleAuthTest.php +++ b/tests/modules/exampleauth/lib/Controller/ExampleAuthTest.php @@ -197,14 +197,14 @@ class ExampleAuthTest extends TestCase /** - * Test that accessing the redirect-endpoint leads to a redirect + * Test that accessing the redirecttest-endpoint leads to a redirect * * @return void */ public function testRedirect(): void { $request = Request::create( - '/redirect', + '/redirecttest', 'GET', ['StateId' => 'someState'] ); @@ -217,21 +217,21 @@ class ExampleAuthTest extends TestCase } }); - $response = $c->redirect($request); + $response = $c->redirecttest($request); $this->assertTrue($response->isSuccessful()); $this->assertInstanceOf(RunnableResponse::class, $response); } /** - * Test that accessing the redirect-endpoint without StateId leads to an exception + * Test that accessing the redirecttest-endpoint without StateId leads to an exception * * @return void */ public function testRedirectMissingStateId(): void { $request = Request::create( - '/redirect', + '/redirecttest', 'GET', ); @@ -240,6 +240,6 @@ class ExampleAuthTest extends TestCase $this->expectException(Error\BadRequest::class); $this->expectExceptionMessage('Missing required StateId query parameter.'); - $c->redirect($request); + $c->redirecttest($request); } } -- GitLab