From c887eadd6bd32c065c8ba53fd1071e4465a7b32c Mon Sep 17 00:00:00 2001
From: Eugene Venter <eugene@catalyst.net.nz>
Date: Fri, 13 Oct 2017 11:07:13 +1300
Subject: [PATCH] getIdpMetadata: add more debug logging
Sometimes there are issues with the metadata itself (e.g metadata
expired). These issues cannot be easily determined, due to the
Exception messages being dropped. In these cases, the current 'not
found' message can be ambiguous.
---
modules/saml/lib/Auth/Source/SP.php | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/modules/saml/lib/Auth/Source/SP.php b/modules/saml/lib/Auth/Source/SP.php
index 504ce9f18..442e763b9 100644
--- a/modules/saml/lib/Auth/Source/SP.php
+++ b/modules/saml/lib/Auth/Source/SP.php
@@ -120,14 +120,15 @@ class sspmod_saml_Auth_Source_SP extends SimpleSAML_Auth_Source {
return $metadataHandler->getMetaDataConfig($entityId, 'saml20-idp-remote');
} catch (Exception $e) {
/* Metadata wasn't found. */
+ SimpleSAML\Logger::debug('getIdpMetadata: ' . $e->getMessage());
}
-
/* Not found in saml20-idp-remote, look in shib13-idp-remote. */
try {
return $metadataHandler->getMetaDataConfig($entityId, 'shib13-idp-remote');
} catch (Exception $e) {
/* Metadata wasn't found. */
+ SimpleSAML\Logger::debug('getIdpMetadata: ' . $e->getMessage());
}
/* Not found. */
--
GitLab