From d4580a1e4ca58bec730d4ef2dcefdc41193c62eb Mon Sep 17 00:00:00 2001
From: Andrius <andrius.kulbis@ktu.lt>
Date: Thu, 27 Oct 2016 11:23:35 +0300
Subject: [PATCH] Fix required attributes duplication

While parsing the XML metadata file of SP, attributes in AttributeConsumerService marked as required where added multiple time causing duplication of attribute keys in attributes.required section.
---
 lib/SimpleSAML/Metadata/SAMLParser.php | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/SimpleSAML/Metadata/SAMLParser.php b/lib/SimpleSAML/Metadata/SAMLParser.php
index 7a4bc2573..7acccd27b 100644
--- a/lib/SimpleSAML/Metadata/SAMLParser.php
+++ b/lib/SimpleSAML/Metadata/SAMLParser.php
@@ -1217,10 +1217,6 @@ class SimpleSAML_Metadata_SAMLParser
             $attrname = $child->Name;
             $sp['attributes'][] = $attrname;
 
-            if ($child->isRequired) {
-                $sp['attributes.required'][] = $attrname;
-            }
-
             if ($child->isRequired !== null && $child->isRequired === true) {
                 $sp['attributes.required'][] = $attrname;
             }
-- 
GitLab