From de8c1d24fdb2448f394023abc37f0aa05ff5e44f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jaime=20Pe=CC=81rez?= <jaime.perez@uninett.no>
Date: Mon, 25 Jul 2016 12:44:46 +0200
Subject: [PATCH] bugfix: Critical configuration errors should not enforce a
baseurlpath.
The code was enforcing this option even if a configuration was passed as a parameter to the constructor. If there is something wrong with a configuration and we are passing it to the constructor, we should know if at least the 'baseurlpath' is correct, and if not, fix it somehow.
This bug was producing a default configuration without 'baseurlpath', when no configuration was passed. In that situation, only the default path (/simplesaml) was working correctly.
---
lib/SimpleSAML/Error/CriticalConfigurationError.php | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/SimpleSAML/Error/CriticalConfigurationError.php b/lib/SimpleSAML/Error/CriticalConfigurationError.php
index 3d036f746..76af87ff8 100644
--- a/lib/SimpleSAML/Error/CriticalConfigurationError.php
+++ b/lib/SimpleSAML/Error/CriticalConfigurationError.php
@@ -48,7 +48,6 @@ class CriticalConfigurationError extends ConfigurationError
{
if ($config === null) {
$config = self::$minimum_config;
- } else {
$config['baseurlpath'] = \SimpleSAML\Utils\HTTP::guessBasePath();
}
--
GitLab