From e3b09ae128161fd76306f0f121c6f17ea14b8331 Mon Sep 17 00:00:00 2001
From: Tim van Dijen <tvdijen@gmail.com>
Date: Tue, 26 Apr 2022 22:03:18 +0200
Subject: [PATCH] Add keys to some dataProviders for more detailed errors
---
tests/lib/SimpleSAML/LoggerTest.php | 16 ++++++++--------
tests/lib/SimpleSAML/Utils/EMailTest.php | 5 ++++-
tests/lib/SimpleSAML/Utils/HTTPTest.php | 4 ++--
3 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/tests/lib/SimpleSAML/LoggerTest.php b/tests/lib/SimpleSAML/LoggerTest.php
index a613cee8d..12a12846d 100644
--- a/tests/lib/SimpleSAML/LoggerTest.php
+++ b/tests/lib/SimpleSAML/LoggerTest.php
@@ -104,14 +104,14 @@ class LoggerTest extends TestCase
public function provideLogLevels(): array
{
return [
- ['emergency', Logger::EMERG],
- ['alert', Logger::ALERT],
- ['critical', Logger::CRIT],
- ['error', Logger::ERR],
- ['warning', Logger::WARNING],
- ['notice', Logger::NOTICE],
- ['info', Logger::INFO],
- ['debug', Logger::DEBUG],
+ 'emergency' => ['emergency', Logger::EMERG],
+ 'alert' => ['alert', Logger::ALERT],
+ 'critical' => ['critical', Logger::CRIT],
+ 'error' => ['error', Logger::ERR],
+ 'warning' => ['warning', Logger::WARNING],
+ 'notice' => ['notice', Logger::NOTICE],
+ 'info' => ['info', Logger::INFO],
+ 'debug' => ['debug', Logger::DEBUG],
];
}
diff --git a/tests/lib/SimpleSAML/Utils/EMailTest.php b/tests/lib/SimpleSAML/Utils/EMailTest.php
index a1dc4be03..08bd0883c 100644
--- a/tests/lib/SimpleSAML/Utils/EMailTest.php
+++ b/tests/lib/SimpleSAML/Utils/EMailTest.php
@@ -89,7 +89,10 @@ class EMailTest extends ClearStateTestCase
*/
public static function mailTemplates(): array
{
- return [['mailtxt.twig'], ['mailhtml.twig']];
+ return [
+ 'TXT template' => ['mailtxt.twig'],
+ 'HTML template' => ['mailhtml.twig']
+ ];
}
diff --git a/tests/lib/SimpleSAML/Utils/HTTPTest.php b/tests/lib/SimpleSAML/Utils/HTTPTest.php
index 855cc91bb..3972d81a6 100644
--- a/tests/lib/SimpleSAML/Utils/HTTPTest.php
+++ b/tests/lib/SimpleSAML/Utils/HTTPTest.php
@@ -563,8 +563,8 @@ class HTTPTest extends ClearStateTestCase
{
// @codingStandardsIgnoreStart
return [
- [null, true],
- ['some-new-browser', true],
+ [null, true],
+ ['some-new-browser', true],
//Browsers that can handle 'None'
// Chrome
['Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.70 Safari/537.36', true],
--
GitLab