From e792f95663dd1bf9128a48b1477018ce9e1af75c Mon Sep 17 00:00:00 2001
From: Thijs Kinkhorst <thijs@kinkhorst.com>
Date: Wed, 24 Apr 2019 18:39:57 +0000
Subject: [PATCH] Make explicit what the role of this password field is.
---
modules/core/templates/loginuserpass.php | 2 +-
modules/core/templates/loginuserpass.twig | 4 ++--
templates/login-ldapmulti.php | 2 +-
templates/login.php | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/modules/core/templates/loginuserpass.php b/modules/core/templates/loginuserpass.php
index cfbb1cf7b..a8b0fe60b 100644
--- a/modules/core/templates/loginuserpass.php
+++ b/modules/core/templates/loginuserpass.php
@@ -89,7 +89,7 @@ if ($this->data['errorcode'] !== null) {
?>
<tr>
<td><label for="password"><?php echo $this->t('{login:password}'); ?></label></td>
- <td><input id="password" type="password" tabindex="2" name="password" /></td>
+ <td><input id="password" type="password" tabindex="2" name="password" autocomplete="current-password" /></td>
<?php
if ($this->data['rememberMeEnabled']) {
// display the remember me checkbox (keep me logged in)
diff --git a/modules/core/templates/loginuserpass.twig b/modules/core/templates/loginuserpass.twig
index 59529528b..ffb6e926d 100644
--- a/modules/core/templates/loginuserpass.twig
+++ b/modules/core/templates/loginuserpass.twig
@@ -53,8 +53,8 @@
<div class="pure-control-group">
<label for="password">{{ 'Password'|trans}}</label>
- <input id="password" type="password" tabindex="2" name="password" class="edge"
- {%- if forceUsername or username %} autofocus {% endif %} />
+ <input id="password" type="password" tabindex="2" name="password" class="edge" autocomplete="current-password"
+ {%- if forceUsername or username %} autofocus {% endif %} >
{% if rememberMeEnabled -%}
</div>
diff --git a/templates/login-ldapmulti.php b/templates/login-ldapmulti.php
index a53da3ebe..b4cf136df 100644
--- a/templates/login-ldapmulti.php
+++ b/templates/login-ldapmulti.php
@@ -51,7 +51,7 @@ foreach ($this->data['ldapconfig'] as $key => $entry) {
<tr>
<td style="padding: .3em;"><?php echo $this->t('password'); ?></td>
- <td><input type="password" tabindex="2" name="password" /></td>
+ <td><input type="password" tabindex="2" name="password" autocomplete="current-password" /></td>
</tr>
<tr><td></td><td>
<button type="submit" tabindex="5" id="mobilesubmit" class="btn"><?php echo $this->t('login_button'); ?></button>
diff --git a/templates/login.php b/templates/login.php
index fd0755db9..fb1d7b951 100644
--- a/templates/login.php
+++ b/templates/login.php
@@ -43,7 +43,7 @@ if (array_key_exists('admin', $this->data)) {
</tr>
<tr>
<td style="padding: .3em;"><?php echo $this->t('password'); ?></td>
- <td><input id="password" type="password" tabindex="2" name="password" /></td>
+ <td><input id="password" type="password" tabindex="2" name="password" autocomplete="current-password" /></td>
</tr>
<tr>
<td></td>
--
GitLab