From efbb3355d714daa5fd13a1c48f135ea753a49722 Mon Sep 17 00:00:00 2001
From: Olav Morken <olav.morken@uninett.no>
Date: Tue, 5 Jul 2011 10:43:24 +0000
Subject: [PATCH] SAML2: Properly initialize DOM elements.
Failure to add the elements to the DOMDocument will result in
canonicalization silently failing.
git-svn-id: https://simplesamlphp.googlecode.com/svn/trunk@2865 44740490-163a-0410-bde0-09ae8108e29a
---
lib/SAML2/XML/md/EntitiesDescriptor.php | 1 +
lib/SAML2/XML/md/EntityDescriptor.php | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/SAML2/XML/md/EntitiesDescriptor.php b/lib/SAML2/XML/md/EntitiesDescriptor.php
index a6b66b88b..e3ea236dc 100644
--- a/lib/SAML2/XML/md/EntitiesDescriptor.php
+++ b/lib/SAML2/XML/md/EntitiesDescriptor.php
@@ -110,6 +110,7 @@ class SAML2_XML_md_EntitiesDescriptor extends SAML2_SignedElementHelper {
if ($parent === NULL) {
$doc = new DOMDocument();
$e = $doc->createElementNS(SAML2_Const::NS_MD, 'md:EntitiesDescriptor');
+ $doc->appendChild($e);
} else {
$e = $parent->ownerDocument->createElementNS(SAML2_Const::NS_MD, 'md:EntitiesDescriptor');
$parent->appendChild($e);
diff --git a/lib/SAML2/XML/md/EntityDescriptor.php b/lib/SAML2/XML/md/EntityDescriptor.php
index bd35f144e..89c7dcefc 100644
--- a/lib/SAML2/XML/md/EntityDescriptor.php
+++ b/lib/SAML2/XML/md/EntityDescriptor.php
@@ -202,6 +202,7 @@ class SAML2_XML_md_EntityDescriptor extends SAML2_SignedElementHelper {
if ($parent === NULL) {
$doc = new DOMDocument();
$e = $doc->createElementNS(SAML2_Const::NS_MD, 'md:EntityDescriptor');
+ $doc->appendChild($e);
} else {
$e = $parent->ownerDocument->createElementNS(SAML2_Const::NS_MD, 'md:EntityDescriptor');
$parent->appendChild($e);
--
GitLab