From efcca9171b8d7e901b6e16a87bd65e48e46aadc2 Mon Sep 17 00:00:00 2001
From: Thijs Kinkhorst <thijs@kinkhorst.com>
Date: Tue, 18 Jan 2022 20:42:46 +0000
Subject: [PATCH] When downloading metadata, add a .xml extension

Closes: #1510

Co-Authored-By: Bart Langelaan <langelaanbart@gmail.com>
---
 modules/saml/www/sp/metadata.php | 1 +
 www/saml2/idp/metadata.php       | 1 +
 2 files changed, 2 insertions(+)

diff --git a/modules/saml/www/sp/metadata.php b/modules/saml/www/sp/metadata.php
index 61fefa104..f330dd7c9 100644
--- a/modules/saml/www/sp/metadata.php
+++ b/modules/saml/www/sp/metadata.php
@@ -47,4 +47,5 @@ $xml = $metaBuilder->getEntityDescriptorText();
 $xml = Metadata\Signer::sign($xml, $spconfig->toArray(), 'SAML 2 SP');
 
 header('Content-Type: application/samlmetadata+xml');
+header('Content-Disposition: attachment; filename="' . basename($sourceId) . '.xml"');
 echo($xml);
diff --git a/www/saml2/idp/metadata.php b/www/saml2/idp/metadata.php
index 6d06c28db..31d3d53f6 100644
--- a/www/saml2/idp/metadata.php
+++ b/www/saml2/idp/metadata.php
@@ -36,6 +36,7 @@ try {
     $metaxml = \SimpleSAML\Metadata\Signer::sign($metaxml, $metaArray, 'SAML 2 IdP');
 
     header('Content-Type: application/samlmetadata+xml');
+    header('Content-Disposition: attachment; filename="idp-metadata.xml"');
 
     echo $metaxml;
     exit(0);
-- 
GitLab