Merge branch '81-fix-delete-finished-training-instance-with-training-runs' into 'master'

Fix delete finished training instance with assigned training runs.

Closes #81

See merge request !80

src/main/java/cz/muni/ics/kypo/training/adaptive/facade/TrainingInstanceFacade.java

@@ -224,8 +224,6 @@ public class TrainingInstanceFacade {
     public void delete(Long trainingInstanceId, boolean forceDelete) {
         TrainingInstance trainingInstance = trainingInstanceService.findById(trainingInstanceId);
         if (forceDelete) {
-            Set<TrainingRun> trainingRunsInTrainingInstance = trainingRunService.findAllByTrainingInstanceId(trainingInstanceId);
-            trainingRunsInTrainingInstance.forEach(tr -> trainingRunService.deleteTrainingRun(tr.getId(), true, false));
             if (!trainingInstance.isLocalEnvironment() && trainingInstance.getPoolId() != null) {
                 sandboxServiceApi.unlockPool(trainingInstance.getPoolId());
                 deleteBashCommandsByPool(trainingInstance.getPoolId());
@@ -239,6 +237,8 @@ public class TrainingInstanceFacade {
                     "First, you must unassign pool id from training instance then try it again."));
             // not possible to delete training instance with associated pool
         }
+        Set<TrainingRun> trainingRunsInTrainingInstance = trainingRunService.findAllByTrainingInstanceId(trainingInstanceId);
+        trainingRunsInTrainingInstance.forEach(tr -> trainingRunService.deleteTrainingRun(tr.getId(), true, false));
         if (trainingInstance.isLocalEnvironment()) {
             deleteBashCommandsByAccessToken(trainingInstance.getAccessToken());
         }