Skip to content
Snippets Groups Projects
Commit 9fda9996 authored by Lukáš Majdan's avatar Lukáš Majdan
Browse files

merge if statements

parent b4abeed3
No related branches found
No related tags found
3 merge requests!135Develop,!133Develop,!132Resolve "add more descriptive error message when a training phase without tasks"
Pipeline #421884 passed with stages
in 3 minutes and 23 seconds
......@@ -549,11 +549,9 @@ public class TrainingRunService {
}
List<AbstractPhase> phases = abstractPhaseRepository.findAllByTrainingDefinitionIdOrderByOrder(trainingInstance.getTrainingDefinition().getId());
for (var phase: phases) {
if (phase instanceof TrainingPhase) {
if (((TrainingPhase) phase).getTasks().isEmpty()) {
throw new EntityConflictException(new EntityErrorDetail(TrainingInstance.class, "id", trainingInstance.getId().getClass(), trainingInstance.getId(),
"Training phase " + phase.getOrder() + " contains no tasks."));
}
if (phase instanceof TrainingPhase && ((TrainingPhase) phase).getTasks().isEmpty()) {
throw new EntityConflictException(new EntityErrorDetail(TrainingInstance.class, "id", trainingInstance.getId().getClass(), trainingInstance.getId(),
"Training phase " + phase.getOrder() + " contains no tasks."));
}
}
return trainingInstance;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment