Skip to content

ad_mu changed to support cyclop workflow

Jednotné přihlášení test requested to merge github/fork/balcirakpeter/ad_mu-cyclop into master

Created by: balcirakpeter

  • Original changes can be found in PR https://github.com/CESNET/perun-services/pull/391
  • This PR is rebased to master. Rebasing process was continualy done on test instance, so it is already tested.
  • Gen script on test instance contained code to include "mandragora" in the email scopes. This was reverted in the final gen script.
  • Gen script also contained "dev-" prefix in DNs. This was erased and original attribute for DNs is used again.
  • Gen script also contained comments from Michal S. saying that for the adGroupDisplayName is used virt attribute instead of def. This comment was removed because the change is already used in production.
  • Gen script also contained some format differences against master so it was reformated.
  • Send script contained a change which forbided to call password_setter subroutine on the test instance. It was uncommented aggain as we want to call that method on production.
  • Again format changes in send script.
  • Send script in production had some parts which were commented (grace_periods). However, they were not commented in the send script from our master branch. This does not matter, because these parts with grace periods were completely erased from the final script.
  • Gen was tested and it generates the same data as in the test instance, except the "mandragora" part in the scope of all emails and "dev-" prefix in DNs. (ad_mu.ldif was checked only partialy. It was not possible to vimdiff these two big files at once).
  • Send script can be compiled but it was not tested.
  • I advise to compare this two files against the files in the test instance not against the files in the master branch.

Merge request reports