Skip to content

fix: propagate the backend offset to the frontend paginator for the...

Bc. Jakub Hejda requested to merge hejda/STR-1211/server_side_offset_fix into main

Description

fix: propagate the backend offset to the frontend paginator for the server-side paginated components

  • Methods for server-side pagination now adjust the offset if the found amount of data is lower than this requested offset.
  • After this change on backend we need to also propagate it to the UI components.

How to test

Prerequisite: deploy related MR on the devel

Entry the component with the paginated entities (e.g. vo/group members, vo groups and its' subgroups, vo/group applications, users under the perun admin, blocked logins and audit messages), move to the bigger page than the found data will contain and then apply the filter. You should be moved to the last possible page. When you delete the filter, you should stay on the page where you were moved during the filtering.

Example:

Page size: 5 -> Try filter "test" - it will find 7 entities in total -> Go to page 3 (11-15 entities) -> Apply the same filter -> You should be moved to page 3 (6-7 entities in this case)

Ideally, try to test also the request time if the new implementation is not much slower.

Author's checklist

  • I have followed the contribution guidelines
  • This MR has been tested or does not change functionality
  • I have added relevant merge request dependencies (if this MR has any)
  • I have added the correct labels
  • I have assigned reviewers (if any are relevant)
  • I have edited the documentation (if the changes require it) or I have noted the need for the change if I do not have access to the documentation
  • I have marked all introduced BREAKING CHANGES or necessary DEPLOYMENT NOTES in the commit message(s)

Reviewer's checklist

  • This MR has been tested or does not change functionality
  • This MR has correct commit message format

Other information

None

Related issues

Closes STR-1211

Edited by Bc. Jakub Hejda

Merge request reports