Skip to content

Draft: refactor(admin): fix and unify selection across list components supporting server-pagination

Michal Berky requested to merge mberky/STR-1387/table_checkbox_service into main

Description

  • Merge table-checkbox-modified.service.ts into table-checkbox.service.ts and replace all usage of the modified version with the main one.
  • Delete the modified version
  • Also had to introduce the table selection refactor into consents-list component so that it stays compatible with table-checkbox service, even though it is not used with checkboxes anywhere in GUI

How to test

I do NOT know where in GUI I can find consents-list component to check if the modification did not break anything. If you are able to, just check that the table works just fine and you get no errors.

Other than that, you can just check if behavior of tables remains unchanged and correct in accordance with the latest changes.

Author's checklist

  • I have followed the contribution guidelines
  • This MR has been tested or does not change functionality
  • I have added relevant merge request dependencies (if this MR has any)
  • I have added the correct labels
  • I have assigned reviewers (if any are relevant)
  • I have edited the documentation (if the changes require it) or I have noted the need for the change if I do not have access to the documentation
  • I have marked all introduced BREAKING CHANGES or necessary DEPLOYMENT NOTES in the commit message(s)

Reviewer's checklist

  • This MR has been tested or does not change functionality
  • This MR has correct commit message format

Other information

Needs to be merged after !1591 (merged). The list of changes will also be drastically lower after it happens, as all of its changes are now also displayed in this one

Closes STR-1387

Merge request reports