Skip to content

fix(cabinet): assign category for publications with categoryId=0

David Flor requested to merge xflord/STR-1185/publications_fix into main

Description

fix(cabinet): assign category for publications with categoryId=0

  • ensures that imported publications will be created
  • matches the logic in WUI
  • removed unused displayName from Author object toString() method, it caused some parsing issues

How to test

Try to import publications through the new GUI app. If you do not have any publications in the external system (most likely), hard code an UCO (e.g., "3988") for the time being in MUStrategy.java:160.

Author's checklist

  • I have followed the contribution guidelines
  • This MR has been tested or does not change functionality
  • I have added relevant merge request dependencies (if this MR has any)
  • I have added the correct labels
  • I have assigned reviewers (if any are relevant)
  • I have edited the documentation (if the changes require it) or I have noted the need for the change if I do not have access to the documentation
  • I have marked all introduced BREAKING CHANGES or necessary DEPLOYMENT NOTES in the commit message(s)

Reviewer's checklist

  • This MR has been tested or does not change functionality
  • This MR has correct commit message format

Other information

I tried to match the logic in WUI (AddPublicationsTabItem.java:717). While this does not seem ideal, a better solution would deserve a more thorough refactor of the Cabinet application.

Related issues

re STR-1185

Edited by David Flor

Merge request reports