Skip to content

Draft: refactor: create new interface OrderColumn and use it in abstract class PageQuery

Bc. Jakub Hejda requested to merge hejda/order_column_interface into main

Description

refactor: create new interface OrderColumn and use it in abstract class PageQuery

  • Create new interface for OrderColumn to remove some boilerplate code.
  • Make the PageQuery class the abstract class.

How to test

Test the paginated methods via RPC.

Author's checklist

  • I have followed the contribution guidelines
  • This MR has been tested or does not change functionality
  • I have added relevant merge request dependencies (if this MR has any)
  • I have added the correct labels
  • I have assigned reviewers (if any are relevant)
  • I have edited the documentation (if the changes require it) or I have noted the need for the change if I do not have access to the documentation
  • I have marked all introduced BREAKING CHANGES or necessary DEPLOYMENT NOTES in the commit message(s)

Reviewer's checklist

  • This MR has been tested or does not change functionality
  • This MR has correct commit message format

Other information

Needs to be finished - probably the custom deserializer needs to be implemented, now there is the RPC error CANNOT_DESERIALIZE_VALUE for sortColumn with only this implementation.

Related issues

TODO: Add relevant issue numbers in the following format (will be added automatically if the MR branch follows our branch naming conventions):

  • closes STR-XXX, closes STR-YYY for issues fully resolved by this MR, or
  • re STR-XXX, STR-YYY for issues only partially resolved by this MR

Merge request reports