Prokop/handle webflow errors
Description
MR for cas-sites changes needs to be created, but otherwise it's ready.
How to test
Find some piece of code that throws the new exception and make it to fail. Config related exceptions are the easiest to trigger.
If you want to test the language, I have steps for chrome:
- go to settings, language, add the language you wanna test, move it to the first place.
- restart browser and voila, CAS(and the new error page with it) will now be in that language(if it's supported) even in the incognito mode.
Author's checklist
-
I have followed the contribution guidelines -
This MR has been tested or does not change functionality -
I have added relevant merge request dependencies (if this MR has any) -
I have added the correct labels -
I have assigned reviewers (if any are relevant) -
I have edited the documentation (if the changes require it) or I have noted the need for the change if I do not have access to the documentation -
I have marked all introduced BREAKING CHANGES or necessary DEPLOYMENT NOTES in the commit message(s)
Reviewer's checklist
-
This MR has been tested or does not change functionality -
This MR has correct commit message format
Other information
There are 2 screenshots of the error page attached to the task but you can see it if you test this too.
Didn't document any of this, should it be? It doesn't require any configuration inside perun scope in the cas.yaml so I dunno.
Note: Exception handling in the redirect subflow proved to be a bit trickier than anticipated so it's not the cleanest but it's the best I could do without spending ton of time on it. In this process I realized it maybe wasn't the best decition to do the redict in a subflow. To be frank I didn't understand why they do it inside CAS like that, so I just copied the approach to be sure... probably would have been better to not do that... if it's ever a problem, it's on me
Related issues
- closes STR-1609