Skip to content

feat: timeout dialog

Pavel Břoušek requested to merge github/fork/BaranekD/timeout_dialog into main

Created by: BaranekD

I have some points to discuss:

  • I have created a separate config file for this feature. I like it, because this PR creates an optional dependency on perun and, in my opinion, it would be nice to have these "perun" features separated.

  • I have enabled the timeout dialog only for muni-jvs. Should I also enable it for bootstrap?

  • Is it ok to keep attr name set to 'rploginurl' as a constant or it should be configurable? (This maybe depends on a previous point?)

Edit: jobs are failing on privacyidea files, however, previous PRs were OK. Did change sth?

Merge request reports