psalm level 4

lib/Auth/Source/OAuth2.php

@@ -330,7 +330,7 @@ class OAuth2 extends Source
     protected function extraAndDecodeJwtPayload(?string $jwt): ?string
     {
         $parts = explode('.', $jwt);
-        if ($parts === false || count($parts) < 3) {
+        if (count($parts) < 3) {
             Logger::warning("authoauth2: idToken '$jwt' is in unexpected format.");
             return null;
         }

lib/Auth/Source/OpenIDConnect.php

@@ -54,7 +54,6 @@ class OpenIDConnect extends OAuth2
                         new FilesystemAdapter('', 0, $cacheDir)
                     )
                 ),
-                'cache'
             )
         );
         return $provider;

lib/Providers/OpenIDConnectProvider.php

@@ -24,9 +24,9 @@ class OpenIDConnectProvider extends AbstractProvider
     protected string $issuer;
 
     /**
-     * @var array
+     * @var ?array
      */
-    private array $openIdConfiguration;
+    private ?array $openIdConfiguration = null;
 
     /**
      * @var string
@@ -103,6 +103,10 @@ class OpenIDConnectProvider extends AbstractProvider
         }
     }
 
+    /**
+     * {@inheritDoc}
+     * @psalm-suppress MoreSpecificImplementedParamType superClass has phpdoc doesn't align with parameter type
+     */
     protected function prepareAccessTokenResponse(array $result)
     {
         $result = parent::prepareAccessTokenResponse($result);

psalm.xml

 <?xml version="1.0"?>
 <psalm
-    errorLevel="6"
+    errorLevel="4"
     hideExternalErrors="true"
     resolveFromConfigFile="true"
     autoloader="vendor/autoload.php"

tests/lib/Auth/Source/LinkedInV2AuthTest.php

@@ -60,7 +60,7 @@ class LinkedInV2AuthTest extends TestCase
         $linkedInAuth = new LinkedInV2Auth(['AuthId' => 'linked'], ['scopes' => ['r_liteprofile']]);
         $state = [];
         /**
-         * @var $mock AbstractProvider|MockObject
+         * @var AbstractProvider|MockObject $mock
          */
         $mock = $this->getMockBuilder(AbstractProvider::class)
             ->disableOriginalConstructor()
@@ -88,7 +88,7 @@ class LinkedInV2AuthTest extends TestCase
 
         $token = new AccessToken(['access_token' => 'abc']);
         /**
-         * @var $mock AbstractProvider|MockObject
+         * @var AbstractProvider|MockObject $mock
          */
         $mock = $this->getMockBuilder(AbstractProvider::class)
             ->disableOriginalConstructor()

tests/lib/Auth/Source/MicrosoftHybridAuthTest.php

@@ -34,7 +34,7 @@ class MicrosoftHybridAuthTest extends TestCase
         $state = [\SimpleSAML\Auth\State::ID => 'stateId'];
 
         /**
-         * @var $mock AbstractProvider|MockObject
+         * @var AbstractProvider|MockObject $mock
          */
         $mock = $this->getMockBuilder(AbstractProvider::class)
             ->disableOriginalConstructor()

tests/lib/Auth/Source/OAuth2Test.php

@@ -264,12 +264,12 @@ class OAuth2Test extends TestCase
         $code = 'theCode';
         $state = [State::ID => 'stateId'];
 
-        /** @var $mock AbstractProvider|MockObject */
+        /** @var AbstractProvider|MockObject $mock */
         $mock = $this->getMockBuilder(AbstractProvider::class)
             ->disableOriginalConstructor()
             ->getMock();
 
-        /** @var $mockRequest RequestInterface|MockObject */
+        /** @var RequestInterface|MockObject $mockRequest */
         $mockRequest = $this->getMockBuilder(RequestInterface::class)
             ->getMock();
 
@@ -370,12 +370,12 @@ class OAuth2Test extends TestCase
         ];
         $state = [State::ID => 'stateId'];
 
-        /** @var $mock AbstractProvider|MockObject */
+        /** @var AbstractProvider|MockObject $mock */
         $mock = $this->getMockBuilder(AbstractProvider::class)
             ->disableOriginalConstructor()
             ->getMock();
 
-        /** @var $mockRequest RequestInterface|MockObject */
+        /** @var RequestInterface|MockObject $mockRequest */
         $mockRequest = $this->getMockBuilder(RequestInterface::class)
             ->getMock();