Skip to content
Snippets Groups Projects
Perun-GitLab Service Account's avatar
commented on merge request !62 "fix: fix bug in bad property name in acrs filter out" at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher

🎉 This MR is included in version 12.3.1 🎉...

Perun-GitLab Service Account's avatar
  • 35b06671 · chore(release): 12.3.1 [skip ci]
Pavel Vyskočil's avatar
deleted branch pvysk/acrs_filter_out_fix at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
Pavel Vyskočil's avatar
accepted merge request !62 "fix: fix bug in bad property name in acrs filter out" at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
Pavel Vyskočil's avatar
Pavel Vyskočil's avatar
pushed to branch pvysk/acrs_filter_out_fix at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
  • 91c90f83 · fix: fix bug in bad property name in acrs filter out
Pavel Vyskočil's avatar
opened merge request !62 "fix: fix bug in bad property name in acrs filter out" at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
Pavel Vyskočil's avatar
pushed new branch pvysk/acrs_filter_out_fix at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
Perun-GitLab Service Account's avatar
commented on merge request !61 "feat: allow filter out acrs by prefix" at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher

🎉 This MR is included in version 12.3.0 🎉...

Perun-GitLab Service Account's avatar
  • 15396d21 · chore(release): 12.3.0 [skip ci]
Pavel Vyskočil's avatar
deleted branch pvysk/allow_acrs_filtering at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
Pavel Vyskočil's avatar
accepted merge request !61 "feat: allow filter out acrs by prefix" at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
Pavel Vyskočil's avatar
Jan Pavlíček's avatar
approved merge request !61 "feat: allow filter out acrs by prefix" at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
Pavel Vyskočil's avatar
pushed to branch pvysk/allow_acrs_filtering at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
  • 06305649 · feat: allow filter out acrs by prefix
Pavel Vyskočil's avatar
pushed to branch pvysk/allow_acrs_filtering at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher
  • a3cd69b9 · feat: allow filter out acrs by prefix
Jan Pavlíček's avatar
commented on merge request !61 "feat: allow filter out acrs by prefix" at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher

Otherwise looks good.

Jan Pavlíček's avatar
commented on merge request !61 "feat: allow filter out acrs by prefix" at Perun / Perun ProxyIdP / v1 / simplesamlphp-module-authswitcher

Personally, I would rename it to filter_acrs_by_prefixes for a clearer understanding of what it does. I had to look into the code to understand tha...