Skip to content
Snippets Groups Projects
Commit 0bce78e6 authored by Thijs Kinkhorst's avatar Thijs Kinkhorst
Browse files

Document that you must set acs.Bindings if you set AssertionConsumerService to a custom array.

The current metadata generation code will first calculate the supported
protocols, then override the ACS'es with the custom array if given. This
makes that the list of supported protocols may no longer be correct.

The nicest fix is if the supported protocols would be calculated also
taking custom ACS specification in account. This however requires
significant refactor of the sp metadata production which is too invasive
for this bugfix release, especially because the problem is solved
differently in master (and there's no test coverage in 1.19 for this
part). Documenting what you need to do is the safest solution here.
parent 96375af5
No related branches found
No related tags found
No related merge requests found
...@@ -124,7 +124,8 @@ Options ...@@ -124,7 +124,8 @@ Options
`AssertionConsumerService` `AssertionConsumerService`
: List of Assertion Consumer Services in the generated metadata. Specified in the array of : List of Assertion Consumer Services in the generated metadata. Specified in the array of
arrays format as seen in the [Metadata endpoints](./simplesamlphp-metadata-endpoints) arrays format as seen in the [Metadata endpoints](./simplesamlphp-metadata-endpoints)
documentation. documentation. Note: you must ensure that you set the `acs.Bindings` option to the set
of bindings that you use here if it is different from the default.
`AssertionConsumerServiceIndex` `AssertionConsumerServiceIndex`
: The Assertion Consumer Service Index to be used in the AuthnRequest in place of the Assertion : The Assertion Consumer Service Index to be used in the AuthnRequest in place of the Assertion
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment