Avoid the friendly names in attribute definitions to end up in the PHP...

Avoid the friendly names in attribute definitions to end up in the PHP generated metadata, as it creates trouble for the AttributeLimit filter and others.

modules/saml/www/sp/metadata.php

@@ -207,6 +207,9 @@ unset($metaArray20['UIInfo']);
 unset($metaArray20['metadata-set']);
 unset($metaArray20['entityid']);
 
+// sanitize the attributes array to remove friendly names
+$metaArray20['attributes'] = array_values($metaArray20['attributes']);
+
 /* Sign the metadata if enabled. */
 $xml = SimpleSAML_Metadata_Signer::sign($xml, $spconfig->toArray(), 'SAML 2 SP');