bugfix: use of undefined variable

2bf88751 · Tim van Dijen · c9d91224 · 2bf88751 · 2bf88751
Commit 2bf88751 authored 6 years ago by Tim van Dijen
--- a/lib/SimpleSAML/IdP/IFrameLogoutHandler.php
+++ b/lib/SimpleSAML/IdP/IFrameLogoutHandler.php
@@ -95,7 +95,9 @@ class IFrameLogoutHandler implements LogoutHandlerInterface
        $t = new \SimpleSAML\XHTML\Template($config, 'IFrameLogoutHandler.twig');
        $t->data['assocId'] = var_export($assocId, true);
        $t->data['spId'] = sha1($assocId);
-        $t->data['errorMsg'] = $error->getMessage();
+        if (!is_null($error)) {
+            $t->data['errorMsg'] = $error->getMessage();
+        }
        $t->show();
        exit(0);
    }

--- a/templates/IFrameLogoutHandler.twig
+++ b/templates/IFrameLogoutHandler.twig
@@ -3,7 +3,7 @@
    <head>
        <title>Logout response from {{ assocId|escape('html') }}</title>
        <script>
-{% if error %}
+{% if errorMsg is defined %}
            window.parent.logoutFailed("{{ spId }}", "{{ errorMsg|escape }}");
 {% else %}
            window.parent.logoutCompleted("{{ spId }}");