Spaces / Braces / Remove dead code

lib/SimpleSAML/Session.php

@@ -251,7 +251,6 @@ class Session implements \Serializable
         }
 
         // check if we have stored a session stored with the session handler
-        $session = null;
         try {
             $session = self::getSession();
         } catch (\Exception $e) {

modules/cas/lib/Auth/Source/CAS.php

@@ -166,10 +166,8 @@ class CAS extends \SimpleSAML\Auth\Source
         {
             case 'validate':
                 return  $this->casValidate($ticket, $service);
-                break;
             case 'serviceValidate':
                 return $this->casServiceValidate($ticket, $service);
-                break;
             default:
                 throw new \Exception("validate or serviceValidate not specified");
         }

modules/core/lib/Auth/Process/AttributeRealm.php

@@ -41,8 +41,6 @@ class AttributeRealm extends \SimpleSAML\Auth\ProcessingFilter
         assert(is_array($request));
         assert(array_key_exists('Attributes', $request));
 
-        $attributes =& $request['Attributes'];
-
         if (!array_key_exists('UserID', $request)) {
             throw new \Exception('core:AttributeRealm: Missing UserID for this user. Please' .
                 ' check the \'userid.attribute\' option in the metadata against the' .

modules/core/lib/Auth/Process/PHP.php

@@ -49,7 +49,7 @@ class PHP extends \SimpleSAML\Auth\ProcessingFilter
         assert(is_array($request));
         assert(array_key_exists('Attributes', $request));
 
-        $function = function(&$attributes) { eval($this->code); };
+        $function = function(/** @scrutinizer ignore-unused */ &$attributes) { eval($this->code); };
         $function($request['Attributes']);
     }
 }

modules/core/www/frontpage_federation.php

@@ -75,7 +75,7 @@ if ($config->getBoolean('enable.shib13-idp', false) === true) {
             $metaentries['remote']['shib13-sp-remote'] = $metadata->getList('shib13-sp-remote');
         }
     } catch (Exception $e) {
-        \SimpleSAML\Logger::error('Federation: Error loading shib13-idp: ' . $e->getMessage());
+        \SimpleSAML\Logger::error('Federation: Error loading shib13-idp: '.$e->getMessage());
     }
 }
 if ($config->getBoolean('enable.adfs-idp', false) === true) {
@@ -89,7 +89,7 @@ if ($config->getBoolean('enable.adfs-idp', false) === true) {
             $metaentries['remote']['adfs-sp-remote'] = $metadata->getList('adfs-sp-remote');
         }
     } catch (Exception $e) {
-        \SimpleSAML\Logger::error('Federation: Error loading adfs-idp: ' . $e->getMessage());
+        \SimpleSAML\Logger::error('Federation: Error loading adfs-idp: '.$e->getMessage());
     }
 }
 

modules/discopower/lib/PowerIdPDisco.php

@@ -272,7 +272,6 @@ class PowerIdPDisco extends \SimpleSAML\XHTML\IdPDisco
         $idpList = $this->processMetadata($t, $idpList, $preferredIdP);
 
         $t->data['idplist'] = $idpList;
-        $faventry = null;
         foreach ($idpList as $tab => $slist) {
             if (!empty($preferredIdP) && array_key_exists($preferredIdP, $slist)) {
                 $t->data['faventry'] = $slist[$preferredIdP];